Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#133 odd code relating to compatibility

1.4.2b1
closed
Thomas Holder
None
5
2014-09-14
2013-04-20
Bob Hanson
No

Very minor point: In the following, in layer3/executive.c, defining ray_trace_fog_start does not have any implications. Is that variable just unnecessary, or is this a bug?

if(session_version < 95) {
  {
    /* adjust fog to reflect current importance of seeing to the Z-slab center w/o fog */

    float fog_start = SettingGetGlobal_f(G, cSetting_fog_start);
    float ray_trace_fog_start = SettingGetGlobal_f(G, cSetting_ray_trace_fog_start);
    if((fog_start == 0.40F) || (fog_start == 0.35F) || (fog_start == 0.30F)) {
      SettingSetGlobal_f(G, cSetting_fog_start, 0.45F);
    }
  }
  ...
}

Discussion

  • Thomas Holder
    Thomas Holder
    2014-09-14

    hm, not sure if you are looking at the same code than me. As far as I can tell, ray_trace_fog_start is used there and that part of the code hasn't been changed sinde 2009.

     
  • Thomas Holder
    Thomas Holder
    2014-09-14

    • status: open --> closed
    • assigned_to: Thomas Holder