#1400 PyDev causing JSP problem annotation disappear

open
Editor (491)
9
2013-05-15
2011-10-07
Anonymous
No

I am reopening bug:
https://sourceforge.net/tracker/?func=detail&aid=3414206&group_id=85796&atid=577332

Installing PyDev causing JSP problem annotation disappear - ID: 3414206
Still having the same problem on 2.2.3 release.

Discussion


  • Anonymous
    2011-10-07

    Screen shot

     
    Attachments

  • Anonymous
    2011-10-07

    • priority: 5 --> 9
     

  • Anonymous
    2011-10-07

    Please see attached screen shot. An problem is marked in JSP editor and problem view but the annotation is still missing on the file in Project Explorer.

    Note: this problem is not limited to JSP file, but also other type problem annotation attached to files.

    Could you double check your earlier fix and test with the steps mentioned above before closing the bug ?

     

  • Anonymous
    2011-10-10

    Note: the issue is slightly improved with the fix for the original bug, but not fully fixed.

    Previously, both the project and the JSP resource did not show the error marker. Now, the project shows the error marker, but the resource still does not.

     

  • Anonymous
    2011-11-18

    HI Fabio, could you take a look of this?
    The error marker is still not showing at resource/file level.

     

  • Anonymous
    2012-10-25

    This bug has been open for a while. Any update?

     
  • Danny Ju
    Danny Ju
    2013-05-06

    I did some debugging and found the issue is caused by
    by the label provider implementation of PyDev CNF viewer.

    In PythonLabelProvider.getImage(Object element), if the element is not
    handled by PyDev, the method should return null, instead of return a default
    image from WorkbenchLabelProvider.

    Otherwise label provider contributed by other plugins will not get
    a chance to decorate the CNF node. (See NavigatorContentServiceLabelProvider.getColumnImage().
    NavigatorContentServiceLabelProvider )

    In the use case above, the label provider which handles flagging error decorator
    in each level of CNF nodes is JDT org.eclipse.jdt.internal.ui.packageview.PackageExplorerLabelProvider, which in term calls ProblemsLabelDecorator.

    I notice PyDev also declare a ProblemsLabelDecorator extension, org.python.pydev.navigator.decorator.ProblemsLabelDecorator, which looks like a copy of JDT. This extension is no longer needed once the bug in PythonLabelProvider.getImage() is fixed.

    Could you fix this asap?

     
  • Danny Ju
    Danny Ju
    2013-05-08

    Any update when the proposed fix above can go be adopted?

     
  • Fabio Zadrozny
    Fabio Zadrozny
    2013-05-08

    Hi Danny,

    Not sure if you've seen it, but I'm working towards continuing PyDev (http://igg.me/at/liclipse). I'll become active again towards fixing things right after the funding is finished.

    Regarding this issue, as you debugged it already, can you create a patch and send a pull request for me at https://github.com/fabioz/Pydev ?

    One thing to note: you mentioned JDT ends up treating it... note that there's the possibility that JDT is not there (if you just get the bare-bones eclipse and add PyDev), so, I don't think the PyDev problems decorator can be removed...

    Cheers,

    Fabio