#22 Fixes for Python 2.4

closed-accepted
nobody
None
5
2005-08-30
2005-07-04
Miloslav Trmac
No

The attached patch contains a few fixes for pychecker
running with
Python 2.4"s more optimized bytecode:

- handle LOAD_CONST of constant tuples
- don"t warn about implicit and explicit returns, there
seems to be no
way to find out whether a return was implicit by
looking at the
bytecode
- handle functions where no return value is known,
happens e.g. using
list generator expressions.

Discussion

  • Eric C. Newton
    Eric C. Newton
    2005-07-08

    Logged In: YES
    user_id=18524

    Thanks... I'll try to get to these patches in the next week, if
    Neal doesn't do it before then. If you don't hear from me,
    bug me again, and I'll add you to the CVS list, and you
    can patch it in yourself.

     
  • Miloslav Trmac
    Miloslav Trmac
    2005-07-30

    Logged In: YES
    user_id=603514

    Ping? I can see no changes in CVS so far.

     
  • Neal Norwitz
    Neal Norwitz
    2005-08-30

    • status: open --> closed-accepted
     
  • Neal Norwitz
    Neal Norwitz
    2005-08-30

    Logged In: YES
    user_id=33168

    These changes seem correct so I checked them in. But it
    would be great if there were tests added for these. There
    are more problems and pychecker really needs so overhauling.

     
  • Miloslav Trmac
    Miloslav Trmac
    2005-08-30

    Logged In: YES
    user_id=603514

    IIRC the bugs fixed manifested in the existing pychecker
    test suite,
    but I could be wrong.

     
  • Neal Norwitz
    Neal Norwitz
    2005-08-30

    Logged In: YES
    user_id=33168

    I forgot to say thank you. So Thank You! I appreciate the
    patch.

    Cool, when I tried pychecker w/2.4 there were so many
    problems, I just ignored them. I want to try to make a
    release and clean up and make another release. I'm trying
    to kickstart development again.