Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#7 Patch fixes erroring out on weird version infos

closed-fixed
Thomas Heller
None
5
2004-07-07
2004-07-07
Cory Dodt
No

Previous to py2exe 0.5.0, having a weird version string
resulted in a warning. Now it becomes a hard error,
and I find this is undesirable. I like putting weird
things in my version! (If there's a way to turn the
behavior off, it wasn't obvious.)

Attached patch supplies a version 0.0 instead of the
unparseable version.

Discussion

  • Cory Dodt
    Cory Dodt
    2004-07-07

    patch.. behave politely toward version strings

     
    Attachments
  • Cory Dodt
    Cory Dodt
    2004-07-07

    • assigned_to: nobody --> theller
     
  • Cory Dodt
    Cory Dodt
    2004-07-07

    Logged In: YES
    user_id=889183

    Assigning to theller for lack of a better target.

     
  • Thomas Heller
    Thomas Heller
    2004-07-07

    • status: open --> closed
     
  • Thomas Heller
    Thomas Heller
    2004-07-07

    • status: closed --> closed-fixed
     
  • Thomas Heller
    Thomas Heller
    2004-07-07

    Logged In: YES
    user_id=11105

    I've reinstalled the warning - I'm against using 0.0 as
    version number when it cannot be parsed.
    Note that you can override the default behaviour anyway by
    subclassing the py2exe command and overriding the
    add_versioninfo() method.

    Thanks for the patch anyway.