Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#11 boot_service.py qualified module name bug fix

closed-out-of-date
nobody
None
5
2006-06-02
2004-11-02
Anonymous
No

boot_service.py doesn't work when the 'modules'
attribute of the service target is qualified with one
or more package names (That is, it contains dots)

This patch seems to fix the problem on my machine.

Discussion

  • boot_service.py.patch

     
    Attachments
  • Mark Hammond
    Mark Hammond
    2006-06-02

    Logged In: YES
    user_id=14198

    I believe this is no longer necessary. boot_service.py now has:

    for name in service_module_names:
    # Use the documented fact that when a fromlist is present,
    # __import__ returns the innermost module in 'name'.
    # This makes it possible to have a dotted name work the
    # way you'd expect.
    mod = __import__(name, globals(), locals(), ['DUMMY'])
    for ob in mod.__dict__.values():
    if hasattr(ob, "_svc_name_"):
    service_klasses.append(ob)

    which I believe is a slightly different way of spelling what
    your patch does.

     
  • Mark Hammond
    Mark Hammond
    2006-06-02

    • status: open --> closed-out-of-date