#73 product_version cannot be set

closed-accepted
nobody
None
5
2005-08-18
2005-08-17
Matthew Thornley
No

In build_exe.py2exe.add_versioninfo(),
Version.product_version is hardcoded to version.
Instead, it should default to version if
get("product_version") returns None. To fix this,
simply change the following:

product_version = version

to

product_version = get("product_version") or version

This solution is much better than forcing the user to
work around the problem.

Discussion

  • Thomas Heller
    Thomas Heller
    2005-08-18

    • status: open --> closed-accepted
     
  • Thomas Heller
    Thomas Heller
    2005-08-18

    Logged In: YES
    user_id=11105

    I've commited this patch without much testing. Thanks!