#72 Buglet in py2exe __init__.py

closed-accepted
Thomas Heller
None
5
2005-08-18
2005-08-04
David Bolen
No

While browsing the py2exe source, I came across the
following in the package's __init__.py:

self.service = attrs.pop("com_server", [])
self.windows = attrs.pop("com_server", [])
self.console = attrs.pop("com_server", [])

Shouldn't the attributes being popped match the object
attributes that are being stored? E.g., the pop should
be using "service", "windows" and "console" respectively?

It doesn't make much practical difference since the
assignment creates an attribute within the Distribution
subclass, so the Distribution __init__ eventually fills
it in, but it looked like it may be a cut 'n paste
oversight.

-- David

Discussion

  • Thomas Heller
    Thomas Heller
    2005-08-18

    • status: open --> closed
     
  • Thomas Heller
    Thomas Heller
    2005-08-18

    Logged In: YES
    user_id=11105

    Fixed. Thanks!

     
  • Thomas Heller
    Thomas Heller
    2005-08-18

    • assigned_to: nobody --> theller
    • status: closed --> closed-accepted