Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#518 dynroute.tcl patch fixing removing items and some more

bugfix
open
nobody
pdtcl (1)
5
2013-12-22
2013-12-22
electrickery
No

The main problem with the script is with the remove message on inlet 1.
This failed to remove the item from the routing list.

Another problem with the script is the usage of un-evaluated catch {}
statements. Like in Java, these make errors disappear without a trace,
not very robust programming. I replaced these by a test.

The last and most minor issue is that the remove function requires the
routed outlet, but does not use it.

The initial bug is patched by replacing line 50:
- catch {dict unset @routing $sel $out}
+ set @routing [dict remove $@routing $sel]

F.J. Kraan, 2013-12-22

1 Attachments

Discussion

  • electrickery
    electrickery
    2013-12-22

    The help patch is also somewhat confusing numbering print output labels
    1, 2, 3 while the routing assignments are 0, 1, 2.

     
    Last edit: electrickery 2013-12-22
    Attachments


Anonymous


Cancel   Add attachments