#53 [expr] number of args in floor and ceil

open
puredata (318)
5
2008-02-25
2006-04-04
Anonymous
No

bug in [expr], in both functions floor and ceil only
one argument is needed:

so in vexp_fun.c:

line 154: {"floor", ex_floor, 2},
line 155: {"ceil", ex_ceil, 2},

should be:

line 154: {"floor", ex_floor, 1},
line 155: {"ceil", ex_ceil, 1},

s.koepf

Discussion

  • Logged In: YES
    user_id=564396
    Originator: NO

    while this is technically a bug in an "external", it practically belongs to "pd-vanilla", so i changed the category and the assigned it to miller.

    while the proposed fix will break patches using floor and ceil, the fix for these patches is trivial (one could write a regexp that does all the search and replace); apart from that, i think one could argue that all patches currently using floor/ceil are aware that they are using a workaround.

     
  • If there are no objections, I'll go ahead and add the trivial patch to fix this.

     


Anonymous


Cancel   Add attachments