Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#7 uname patch for setup.py with windows

open
nobody
1
2006-09-20
2006-09-20
OvermindDL1
No

Patch for setup.py to put the windows test after the
uname test. Just a little change, but all of my
windows machines have the gnu-tools set, which include
uname, so may as well use it. Included is the patch
file, pasted below this is the changed function itself
(the patch does not include my comments. You may even
want to refer Windows users to the useful gnu-tools on
sourceforge in your readme.

Discussion

  • OvermindDL1
    OvermindDL1
    2006-09-20

    setup.py patch file

     
    Attachments
  • OvermindDL1
    OvermindDL1
    2006-09-20

    • priority: 5 --> 1
     
  • Armin Rigo
    Armin Rigo
    2006-09-22

    Logged In: YES
    user_id=4771

    Did you test the patch with no 'uname' in your path?
    I'm afraid of the confusing error message that we get
    when os.popen-ing it then.

     
  • OvermindDL1
    OvermindDL1
    2006-09-22

    Logged In: YES
    user_id=1602853

    Yes, I removed the uname from my path, deleted the psyco
    build directory, and it still worked, sorry for not
    mentioning that earlier. Although I only tested on Windows,
    it should work identically as before on other systems as the
    only they did before that, that they did not do now is test
    if the system platform starts with "win". The reason I did
    this, although it worked before, is that windows can be a
    64-bit installation now, and thus would not work with psyco
    currently. Therefore, if the user is savvy enough to have
    the gnu-tools for windows installed, then psyco will get the
    right info, seeing that the system is 64-bit instead of just
    seeing the bulk 'windows', and not installing, instead of
    failing during compile, or worse, compiling but not working
    properly.