Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#45 alignment error for AMR processors

closed-fixed
None
5
2006-10-07
2006-09-19
Victor Jaquez
No

There's an error in the r_drawflush.inl file in the SVN
version for AMR processors, where a int cast produce a
structure unaligment, generating a SIGBUS.

Discussion

  • Victor Jaquez
    Victor Jaquez
    2006-09-19

    Patch for the r_drawflush.inl file

     
    • assigned_to: nobody --> proff_fs
    • status: open --> open-later
     
  • Logged In: YES
    user_id=18721

    The whole point of this is to use int instead of bytes to get faster writing. But the
    bus error shows that we can get unaligned writes, which aren't fatal on other
    processors, but hurt performance. I will look into rewriting this in a way which
    should lead to better performance on most processors and fixes the bus error
    on those where unalign access is forbidden. Thanks for bringing this up.

     
  • Logged In: YES
    user_id=18721

    I hopefully fixed this for PrBoom 2.4.6. Please open a bug if it still happens.

     
    • status: open-later --> closed-fixed