#25 All players in a netgame are green.

closed-accepted
Colin Phipps
4
2004-09-05
2000-11-28
Oliver Kraus
No

When I first started a netgame, all players except the
first are black. The first player was green.

Well, this is a big-endian problem:
g_game.c line 769, G_Ticker():
int net_cl = LONG(mapcolor_me);

After fixing this, all players are green.
I think the problem is the distribution
of the color in G_Ticker(), line 770
with 'D_NetSendMisc'.

Each prboom already has a unique number
(consoleplayer) and I think the color should
be directly derived from that color. There should
be no need to distribute the color.
Indeed after removing 'D_NetSendMisc',
colors are different for each player.

Oli

Discussion

  • Colin Phipps
    Colin Phipps
    2000-11-29

    Yes, I should probably remove the broken player colours feature until I get around to the networking rewrite. Hmmm.

     
  • Colin Phipps
    Colin Phipps
    2000-11-29

    • priority: 5 --> 4
    • assigned_to: nobody --> cph
     
  • Logged In: YES
    user_id=433019

    Last message in this topic dates 2000-11-29... mmmh...
    looks like "simply changing colors" is not *that* simple, is it?

     
  • Jolan Luff
    Jolan Luff
    2003-01-12

    Logged In: YES
    user_id=659839

    Oli, do you have a patch to fix the endian issue?

     
  • Logged In: YES
    user_id=18721

    It's a feature. You can change your colour on the second page
    of the automap colours and for >=2.3.1 in the multiplayer
    settings.
    When deathmatching it's better that everyone is green or the
    players with darker colours could have an advantage.
    When you play with teams everyone in the same team can
    choose the same colour.

     
    • status: open --> closed-accepted