Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#199 r4080: FTBFS with gcc-4.6

closed-fixed
nobody
None
5
2011-09-28
2011-09-28
Joshua Beck
No

r4080 doesn't compile as-is with gcc-4.6. It gives a whole bunch of errors. The included patch fixes them.

Discussion

  • Joshua Beck
    Joshua Beck
    2011-09-28

    Patch to fix gcc-4.6 errors

     
    Attachments
  • Andrey Budko
    Andrey Budko
    2011-09-28

    • status: open --> closed-fixed
     
  • Andrey Budko
    Andrey Budko
    2011-09-28

    fixed?

     
  • Joshua Beck
    Joshua Beck
    2011-09-28

    Yeah, r4081 compiles as-is.

     
  • Joshua Beck
    Joshua Beck
    2011-09-28

    Hold on:

    When I went to make a patch against r4081, I found this:

    ===================================================================
    --- src/gl_preprocess.c (revision 4081)
    +++ src/gl_preprocess.c (working copy)
    @@ -32,6 +32,9 @@
    #ifdef HAVE_CONFIG_H
    #include "config.h"
    #endif
    +#ifndef CALLBACK
    +#define CALLBACK
    +#endif

    #ifdef _WIN32
    #define WIN32_LEAN_AND_MEAN
    Index: src/gl_texture.c

    If this change isn't included in gl_preprocess.c, it fails to compile with gcc-4.6.

     
  • Andrey Budko
    Andrey Budko
    2011-09-28

    What? r4081 already has this block
    #ifndef CALLBACK
    #define CALLBACK
    #endif

    after #ifdef _WIN32 block

     
  • Joshua Beck
    Joshua Beck
    2011-09-29

    I went and checked the browsable SVN repository and you're right. I have no idea why Subversion thinks that gl_preprocess.c r4081 differs from my working directory.