#101 Huge Cleanup Patch

closed-accepted
nobody
Core (27)
5
2011-07-26
2011-07-18
Dale Blount
No

Move tMessage errors into flash_error/info calls
Removed <span class=\"error_msg\"> from all of the templates and language files and cleaned up flash_info/error display.
Added a 3rd/4th <td> on pages where errors were overwriting the labels. Created new _text_error variables to hold these instead of the current _text variables.
Ran HTML tidy and fixed all errors (except errors coming from the message defaulted inside of <textarea> of the vacation pages.
Fixed date detection in users/vacation.php
Probably something else that I forgot.

Discussion

  • Dale Blount
    Dale Blount
    2011-07-18

    huge patch

     
    Attachments
  • Dale Blount
    Dale Blount
    2011-07-18

    new file required by patch

     
    Attachments
  • Dale Blount
    Dale Blount
    2011-07-19

    background for login page

     
    Attachments
  • Dale Blount
    Dale Blount
    2011-07-19

    <cboltz> supa_user: I'm just reading your patch
    <cboltz> first question: you refer to ../images/mail_bg.gif in the CSS - can you please upload that image to the SF tracker? ;-)

    done.

    <cboltz> second question: what's the reason for removing background:#ffffff; color:#000000 for body in the CSS?

    Accidental. Removed it to test some things and forgot to add it back.

    <cboltz> third question: I guess you changed model/MailboxHandler before writing smtp_get_admin_email() ? ;-)
    <cboltz> Or is there a special reason not to use that function there?

    I wasn't sure authentication_get_username() would work correctly in model/CLI mode and really haven't used it to be able to say if it was working correctly or not.

    <cboltz> and one more: you made message.tpl empty (while dropping all $tMessage) - is there a reason for still refering to it in smarty_template in various files?

    oversight. I removed all the files that called it, but forgot to remove the comments.

    <cboltz> another one: why did you wrap the input fields in users_login.tpl with <div class="field_container"> ... </div> ?

    Oops. That's something we tried and then reverted and must have missed that one. It's OK to remove.

     
  • Commited to SVN trunk in lots of small parts, the final one was r1128.

    Thanks for your work on PostfixAdmin!

     
    • status: open --> closed-accepted