[ postfixadmin-Bugs-1698485 ] vacation.pl source address problem.

[SourceForge.net <no...@so...>]

Bugs item #1698485, was opened at 2007-04-11 16:07
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=1698485&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: vacation.pl source address problem.

Initial Comment:
If a mail is sent to the vacation with an header to like: 
To: "pippo" <pi...@di...>

The vacation.pl will try to run sendmail with these arguments:

sendmail -t -f "pippo" <pi...@di...>

as you can see the arguments are incorrect and sendmail will die.





----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2007-10-05 02:53

Message:
Logged In: YES 
user_id=593261
Originator: NO

In the meantime, vacation.pl has been replaced by the former
vacation-pgsql.pl.

I just checked the code - as far as I can say, this fix is included.
Please test it using the latest SVN version and reopen this bugreport if
necessary.

----------------------------------------------------------------------

Comment By: Dalibor Straka (dast_panelnet)
Date: 2007-09-28 18:40

Message:
Logged In: YES 
user_id=1678716
Originator: NO

Here is a patch that fixes this bug in 2.1.0 version

diff -ur a/vacation.pl b/vacation.pl
--- a/vacation.pl       2007-09-28 18:36:31.000000000 +0200
+++ b/vacation.pl       2007-09-28 18:37:55.000000000 +0200
@@ -160,7 +160,7 @@
       my @row = $sth->fetchrow_array;
       if (do_cache ($email, $orig_from)) { return; }
       do_debug ("[SEND RESPONSE] for $orig_messageid:\n", "FROM: $email
(orig_to: $orig_to)\n", "TO: $orig_from\n", "SUBJECT: $orig_subject\n",
"VACATION SUBJECT: $row[0]\n", "VACATION BODY: $row[1]\n");
-      do_mail ($orig_to, $orig_from, $row[0], $row[1]);
+      do_mail ($email, $orig_from, $row[0], $row[1]);
       do_log ($orig_messageid, $orig_to, $orig_from, $orig_subject); 
    }


----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2007-04-29 22:06

Message:
Logged In: NO 

In line 85 of vacation script change $email to '$email'

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=1698485&group_id=191583