SF.net SVN: postfixadmin:[1584] trunk/model/PFAHandler.php

[<chr...@us...>]

Revision: 1584
          http://sourceforge.net/p/postfixadmin/code/1584
Author:   christian_boltz
Date:     2013-11-16 19:10:15 +0000 (Sat, 16 Nov 2013)
Log Message:
-----------
PFAHandler:
- read_from_db(): convert $limit and $offset with (int) to make sure
  they contain a sane value

Modified Paths:
--------------
    trunk/model/PFAHandler.php

Modified: trunk/model/PFAHandler.php
===================================================================
--- trunk/model/PFAHandler.php	2013-11-16 19:02:44 UTC (rev 1583)
+++ trunk/model/PFAHandler.php	2013-11-16 19:10:15 UTC (rev 1584)
@@ -460,9 +460,9 @@
 
         $query = "SELECT $cols FROM $table $extrafrom $where ORDER BY " . $this->id_field;
 
+        $limit  = (int) $limit; # make sure $limit and $offset are really integers
+        $offset = (int) $offset;
         if ($limit > -1 && $offset > -1) {
-            # TODO: make sure $limit and $offset are really integers - cast via (int) ?
-            # TODO: make sure $limit is > 0 (0 doesn't break anything, but guarantees an empty resultset, so it's pointless)
             $query .= " LIMIT $limit OFFSET $offset ";
         }
 

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.