Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#48 one function for sending mail

open
nobody
Core (30)
5
2013-12-01
2009-03-11
Christian Boltz
No

from https://sourceforge.net/tracker2/?func=detail&atid=937964&aid=2682897&group_id=191583

I think there should be the only function for mail sending that can be used in broadcast-message.php, sendmail.php, create-mailbox.php. Also I think that base64 encoding of message body in broadcast-message.php isn't necessary - plain text would be better.

Discussion

  • GingerDog
    GingerDog
    2009-03-12

    I'd rather we used e.g. PEAR::Mail or Zend_Mail or SwiftMailer (delete/add as appropriate) and not try talking SMTP or deal with encoding issues.

     
  • First step: some (but not all) files call smtp_mail() (defined in functions.inc.php). The remaining files need to be changed sooner or later.

    Switching to some "external" class can then be done in a second step - or not, as long as smtp_mail works ;-) (and I don't remember bugreports about it...). Additionally, the mails that postfixadmin sends are text/plain - no attachments, no multipart etc., just plain and easy to handle text.