vacation.pl changes in v2.3.4

2011-11-16
2013-01-23
  • killerbees19
    killerbees19
    2011-11-16

    Hello,

    I found this line in the current changelog:

    fix vacation.pl to log to "mail" syslog facility
    

    But all files in VIRTUAL_VACATION are the same as in v2.3.3, only the "Revision" line were changed.

    Where is the change? Or is it an error in the changelog?

    Regards,
    Christian

     
  • You'll have to look very close at it to spot the difference ;-)

    svn diff -r1073:1074
    Index: CHANGELOG.TXT
    ===================================================================
    --- CHANGELOG.TXT       (Revision 1073)
    +++ CHANGELOG.TXT       (Revision 1074)
    @@ -21,3 +21,4 @@
     - fix vacation.pl to log to "mail" syslog facility
    
     Version 2.3.3 - 2011/03/14 - SVN r1010 (postfixadmin-2.3 branch)
     ---------------------------------------------------------------
    Index: VIRTUAL_VACATION/vacation.pl
    ===================================================================
    --- VIRTUAL_VACATION/vacation.pl        (Revision 1073)
    +++ VIRTUAL_VACATION/vacation.pl        (Revision 1074)
    @@ -213,4 +213,4 @@
         if($syslog == 1) {
             my $syslog_appender = Log::Log4perl::Appender->new(
                 'Log::Dispatch::Syslog',
    -            Facility => 'mail',
    +            facility => 'mail',
    

    So the change is _F_acility -> _f_acility (uppercase vs. lowercase f) ;-)

    This fix was commited to trunk in r1073 and the 2.3 branch in r1074, which means 2.3.4 is the first release containing the fix.

    Note: I checked this in SVN, not the tarball. If vacation.pl from the 2.3.4 tarball still has uppercase "Facility", please complain ;-)

     
  • killerbees19
    killerbees19
    2011-11-17

    I'm sorry, my diff program (I checked all directories with WinMerge) was configured to work case insensitive. I forgot to change this setting after the Windows reinstall. My fault, thanks for the hint :-)

    Regards,
    Christian