#272 vacation: subject not being encoded

closed-fixed
nobody
Vacation (31)
5
2013-12-01
2012-04-19
Juraj Lutter
No

Please use encode_mimewords() for $subject in %mail.

Discussion

    • summary: subject not being encoded --> vacation: subject not being encoded
     
  • Here's the patch (tested):

    --- vacation.pl.orig 2011-06-23 23:53:07.000000000 +0300
    +++ vacation.pl 2013-02-07 04:50:50.943816588 +0200
    @@ -447,7 +447,7 @@
    my %mail;
    # I believe Mail::Sender qp encodes the subject, so we no longer need to.
    %mail = (
    - 'subject' => $subject,
    + 'subject' => encode_mimewords($subject, 'Charset', 'UTF-8'),
    'from' => $from,
    'to' => $to,
    'msg' => encode_base64($body)

     
  • Line "# I believe Mail::Sender qp encodes the subject, so we no longer need to" should be removed, as this is not the case.

     
    • status: open --> closed-fixed
    • Group: --> SVN (please specify revision!)
     
  • Thanks for the patch!

    Fixed in SVN trunk r1597 and 2.3 branch r1598.