Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#40 Mantis ID:7962 - Item UOM conversions use different validators on different forms.

open
nobody
None
3
2008-12-09
2008-12-09
omfgppc
No

Reporter: petebisson
Severity: Patch
Category: Products
Project: xTupleApps

Version:

Description:
Different input validators are used on the _fromValue and _toValue widgets displayed in:

Products - Item - Conversions - UoM
[itemUOM - uses omfgThis->qtyVal()]
and
Products - Master Information - UoM - Conversions
[uomConv - uses omfgThis->ratioVal()]

The locale-specific decimal places for these validators may be configured independently in System - Master Information - Locales ...

This can lead to inconsistencies when configuring item UoMs using decimal fractions.

Steps to reproduce:

Additional information:
The definition of _ratioVal specifies it should use decimalPlaces("uomratio"), which seems the appropriate value for these Item UoM conversions.

The provided patch switches the two validators in itemUOM to use ratioVal() instead of qtyVal()

No impact analysis has been done regarding legacy data, as I don't have any ;-)

Read more at http://www.xtuple.org/mantis/view.php?id=7962

Discussion