From: phil r. <phi...@ya...> - 2013-09-26 14:31:02
|
Sorry to dop this in when clearly there is plenty else to do, but maybe this is an easy fix before the release. I just tried to build the latest trunk version ahead of the planned release and the wxWidgets build is broken - at least on windows. The wxWidget related files are given debug compiler options (_DEBUG __WXDEBUG__) even for release build. I think this has been discussed before on the list, but i couldn't find the cause. I've just had a trawl through the code and basically FindwxWidgets.cmake always returns these options in wxWidgets_DEFINITIONS_DEBUG regardless of whether we are in a debug build or not. it's not entirely clear if this is a bug in CMake or if it is by design. The documentation says wxWidgets_DEFINITIONS_DEBUG- Contains defines required to compile/link against WX debug builds, e.g. __WXDEBUG__. So it hints that maybe it's up to the calling build system to check the build type and apply the definitions if needed. Unfortunately i don't know CMake well enough to fix this. I assume it is an if statement around line 78 of wxwidgets.cmake to check the build type or something. Anyway, if it has to wait until after the release then so be it. Phil |
From: Andrew R. <and...@us...> - 2013-09-26 14:49:26
|
Phil, Thanks - I've tested this and it seems to make no difference to the map to me. I can see all the parts of Antarctica I would expect to see anyway. I wonder if this is a windows issue with the shapefile support? The only change I see is in the axis labels. Changing the range changes which values are labelled. I'll send you an image separately of with / without your changes so you can confirm if we are seeing the same thing. Thanks Andrew On Thursday 26 Sep 2013 02:19:17 phil rosenberg wrote: Hi Alan Meant to drop this in to you some time back. A very minor patch to fix the x19 missing bit of antarctica on the global map. The problem was that the axes went beyond the -360 to +360 degrees that the map routines draw on since the shapefile changes. Changing these limits was all that was needed. The patch covers C and C++. I was tempted to go through and make changes to the other bindings as it was so minor, but i don't have things set up to even compile them so I thought I had better not. Phil |
From: Andrew R. <and...@us...> - 2013-09-26 14:54:55
|
Actually, looking back I see that this _does_ fix some issues for me, but with Alaska, not Antarctica. Is this what you meant or are we seeing different issues? Anyway, I'll go ahead and commit your change to all languages. Andrew On Thursday 26 Sep 2013 15:49:12 Andrew Ross wrote: Phil, Thanks - I've tested this and it seems to make no difference to the map to me. I can see all the parts of Antarctica I would expect to see anyway. I wonder if this is a windows issue with the shapefile support? The only change I see is in the axis labels. Changing the range changes which values are labelled. I'll send you an image separately of with / without your changes so you can confirm if we are seeing the same thing. Thanks Andrew On Thursday 26 Sep 2013 02:19:17 phil rosenberg wrote: Hi Alan Meant to drop this in to you some time back. A very minor patch to fix the x19 missing bit of antarctica on the global map. The problem was that the axes went beyond the -360 to +360 degrees that the map routines draw on since the shapefile changes. Changing these limits was all that was needed. The patch covers C and C++. I was tempted to go through and make changes to the other bindings as it was so minor, but i don't have things set up to even compile them so I thought I had better not. Phil |
From: Andrew R. <and...@us...> - 2013-09-26 15:31:52
|
Phil, wxWidgets works fine on my Ubuntu Linux system. I've checked and I can see no evidence of debug flags in the wxwidgets build, so I'm guessing it is either a windows issue or an issue with the specific wxwidgets version. I've just committed a change so cmake will only add the options if CMAKE_BUILD_TYPE is set to Debug. Alan, you might also want to cast your eye over this to make sure you are happy. Andrew On Thursday 26 Sep 2013 07:30:37 phil rosenberg wrote: Sorry to dop this in when clearly there is plenty else to do, but maybe this is an easy fix before the release. I just tried to build the latest trunk version ahead of the planned release and the wxWidgets build is broken - at least on windows. The wxWidget related files are given debug compiler options (_DEBUG __WXDEBUG__) even for release build. I think this has been discussed before on the list, but i couldn't find the cause. I've just had a trawl through the code and basically FindwxWidgets.cmake always returns these options in wxWidgets_DEFINITIONS_DEBUG regardless of whether we are in a debug build or not. it's not entirely clear if this is a bug in CMake or if it is by design. The documentation says wxWidgets_DEFINITIONS_DEBUG- Contains defines required to compile/link against WX debug builds, e.g. __WXDEBUG__. So it hints that maybe it's up to the calling build system to check the build type and apply the definitions if needed. Unfortunately i don't know CMake well enough to fix this. I assume it is an if statement around line 78 of wxwidgets.cmake to check the build type or something. Anyway, if it has to wait until after the release then so be it. Phil |
From: Alan W. I. <ir...@be...> - 2013-09-26 17:01:03
|
On 2013-09-26 02:19-0700 phil rosenberg wrote: > Hi Alan > Meant to drop this in to you some time back. A very minor patch to fix the x19 missing bit of antarctica on the global map. The problem was that the axes went beyond the -360 to +360 degrees that the map routines draw on since the shapefile changes. Changing these limits was all that was needed. > The patch covers C and C++. I was tempted to go through and make changes to the other bindings as it was so minor, but i don't have things set up to even compile them so I thought I had better not. Hi Phil: Thanks for your patch. I am going to put off considering this patch until post-release since its too late for this release. Nevertheless, it does sound like your patch (and its propagation to all the other languages) should be first on our agenda post-release. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Alan W. I. <ir...@be...> - 2013-09-26 18:10:37
|
On 2013-09-26 10:00-0700 Alan W. Irwin wrote: > On 2013-09-26 02:19-0700 phil rosenberg wrote: > >> Hi Alan > >> Meant to drop this in to you some time back. A very minor patch to > fix the x19 missing bit of antarctica on the global map. The problem > was that the axes went beyond the -360 to +360 degrees that the map > routines draw on since the shapefile changes. Changing these limits > was all that was needed. > >> The patch covers C and C++. I was tempted to go through and make > changes to the other bindings as it was so minor, but i don't have > things set up to even compile them so I thought I had better not. > > Hi Phil: > > Thanks for your patch. > > I am going to put off considering this patch until post-release since > its too late for this release. Nevertheless, it does sound like your > patch (and its propagation to all the other languages) should be first > on our agenda post-release. Just to clarify, I didn't read my e-mail INBOX sufficiently before my reply above, and it turned out that Andrew had already got your patch and the further language propagations into this release which is great. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Alan W. I. <ir...@be...> - 2013-09-26 18:03:27
|
Hi Andrew: Thanks very much for all your testing and patching work this morning. For example, I didn't have time to deal with Phil's example 19 patch, but you did which I appreciate. More below. On 2013-09-26 16:31+0100 Andrew Ross wrote: > > Phil, > > wxWidgets works fine on my Ubuntu Linux system. I've checked and I can see no > evidence of debug flags in the wxwidgets build, so I'm guessing it is either a windows > issue or an issue with the specific wxwidgets version. I've just committed a change so > cmake will only add the options if CMAKE_BUILD_TYPE is set to Debug. > > > > Alan, you might also want to cast your eye over this to make sure you are happy. I frankly don't understand the purpose of the relevant CMake logic block but putting an extra AND CMAKE_BUILD_TYPE MATCHES "Debug" qualifier on whether that block of logic is run seems right to me since you should only want the debug version of the wxwidgets library when CMAKE_BUILD_TYPE MATCHES "Debug". @Arjen: are you in a position to do a quick test of this new wxwidgets logic on Cygwin? @Phil: please also test the new logic to see if it sorts out the problem you discovered. @Andrew: I doubt I will have a chance to test out this change on Wine, but I don't think it will make a difference in that case since my Wine build of the wxwidgets libraries did not involve debug versions as far as I know. Which implies wxWidgets_DEFINITIONS_DEBUG will not be set to true so this logic block will be skipped in my Wine case regardless of your AND CMAKE_BUILD_TYPE MATCHES "Debug" addition to the if condition. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: phil r. <phi...@ya...> - 2013-09-26 19:45:26
|
Thanks also from me Andrew The change seems to have worked. I think for the first time ever I can now build PLplot how I need from scratch from CMake without having to go into Visual Studio with a list of tweeks I need to make. I think that in itself is a great achievement for the next version. It does say in the comments at the top of FindwxWidgets.cmake that it uses totally different methods for linux(where it uses wxconfig) and Windows(where it doesn't). But if the outputs are different then presumably this is a CMake bug so I'll report it. Now that PLplot can be built "out of the box" with Visual Studio I'll add a full walkthrough to the wiki of building PLplot in VS with options for shapelib, wxWidgets, AGG and Freetype. Thanks again guys Phil ________________________________ From: Alan W. Irwin <ir...@be...> To: Arjen Markus <arj...@de...>; Andrew Ross <and...@us...> Cc: PLplot development list <plp...@li...>; phil rosenberg <phi...@ya...> Sent: Thursday, 26 September 2013, 19:03 Subject: Re: [Plplot-devel] CMake bug report - sorry Hi Andrew: Thanks very much for all your testing and patching work this morning. For example, I didn't have time to deal with Phil's example 19 patch, but you did which I appreciate. More below. On 2013-09-26 16:31+0100 Andrew Ross wrote: > > Phil, > > wxWidgets works fine on my Ubuntu Linux system. I've checked and I can see no > evidence of debug flags in the wxwidgets build, so I'm guessing it is either a windows > issue or an issue with the specific wxwidgets version. I've just committed a change so > cmake will only add the options if CMAKE_BUILD_TYPE is set to Debug. > > > > Alan, you might also want to cast your eye over this to make sure you are happy. I frankly don't understand the purpose of the relevant CMake logic block but putting an extra AND CMAKE_BUILD_TYPE MATCHES "Debug" qualifier on whether that block of logic is run seems right to me since you should only want the debug version of the wxwidgets library when CMAKE_BUILD_TYPE MATCHES "Debug". @Arjen: are you in a position to do a quick test of this new wxwidgets logic on Cygwin? @Phil: please also test the new logic to see if it sorts out the problem you discovered. @Andrew: I doubt I will have a chance to test out this change on Wine, but I don't think it will make a difference in that case since my Wine build of the wxwidgets libraries did not involve debug versions as far as I know. Which implies wxWidgets_DEFINITIONS_DEBUG will not be set to true so this logic block will be skipped in my Wine case regardless of your AND CMAKE_BUILD_TYPE MATCHES "Debug" addition to the if condition. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Arjen M. <Arj...@de...> - 2013-09-27 06:17:44
|
Hi Alan, > -----Original Message----- > From: Alan W. Irwin [mailto:ir...@be...] > > @Arjen: are you in a position to do a quick test of this new wxwidgets logic on > Cygwin? > I haven't looked at wxWidgets under Cygwin yet, so this will be a post-release action, but I will give it a try. Regards, Arjen DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail. |
From: Phil R. <phi...@ya...> - 2013-09-26 19:09:39
|
Perhaps it was Alaska, i just remembered Alan mentioning it after i added the shapefile support, then some months ago i found the reason while looking at something else. Sorry i didn't reply earlier today. I was fighting with the cmake build stuff. Thanks for propagating the fix. Phil -----Original Message----- From: "Alan W. Irwin" <ir...@be...> Sent: 26/09/2013 19:10 To: "phil rosenberg" <phi...@ya...> Cc: "plp...@li..." <plp...@li...> Subject: Re: [Plplot-devel] x19 patch On 2013-09-26 10:00-0700 Alan W. Irwin wrote: > On 2013-09-26 02:19-0700 phil rosenberg wrote: > >> Hi Alan > >> Meant to drop this in to you some time back. A very minor patch to > fix the x19 missing bit of antarctica on the global map. The problem > was that the axes went beyond the -360 to +360 degrees that the map > routines draw on since the shapefile changes. Changing these limits > was all that was needed. > >> The patch covers C and C++. I was tempted to go through and make > changes to the other bindings as it was so minor, but i don't have > things set up to even compile them so I thought I had better not. > > Hi Phil: > > Thanks for your patch. > > I am going to put off considering this patch until post-release since > its too late for this release. Nevertheless, it does sound like your > patch (and its propagation to all the other languages) should be first > on our agenda post-release. Just to clarify, I didn't read my e-mail INBOX sufficiently before my reply above, and it turned out that Andrew had already got your patch and the further language propagations into this release which is great. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |
From: Arjen M. <Arj...@de...> - 2013-11-03 12:55:51
|
Hi Alan, > -----Original Message----- > @Arjen: are you in a position to do a quick test of this new wxwidgets logic on > Cygwin? > Unfortunately, I still get errors while building wxWidgets under Cygwin. Even with the latest version, 2.9.5, and turning UNICODE support off (from the error messages I got I assumed the compile errors were associated with UNICODE support, but alas, this did not help one bit). Regards, Arjen DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail. |
From: Alan W. I. <ir...@be...> - 2013-11-03 18:05:05
|
On 2013-11-03 12:55-0000 Arjen Markus wrote: > Hi Alan, > >> -----Original Message----- >> @Arjen: are you in a position to do a quick test of this new wxwidgets logic on >> Cygwin? >> > > Unfortunately, I still get errors while building wxWidgets under Cygwin. Even with the latest version, 2.9.5, > and turning UNICODE support off (from the error messages I got I assumed the compile errors were associated > with UNICODE support, but alas, this did not help one bit). Hi Arjen: My success with wxwidgets builds (both on Linux and MinGW/MSYS) and PLplot builds that use those wxwidgets builds has been with wxwidgets version 2.8.12, (important) CXXFLAGS=-fno-keep-inline-dllexport, and with the wxwidgets configure options --prefix=<installprefix> --enable-shared --enable-unicode --enable-debug --enable-debug_gdb So please use that exact combination for all further testing until you gain some success. Also, could you clarify whether it is the wxwidgets software build that is failing or the PLplot build? If wxwidgets, please give exact details such as the CXXFLAGS setting, exact configure options you used, the complete configure output and the complete make output. If PLplot, please give all the required information (compile flags if any, cmake arguments, complete cmake output, cache file, complete VERBOSE=1 make output) I have requested whenever you have reported a PLplot issue before. Also, if you are not getting anywhere on Cygwin, please try to mimic what I did exactly on MinGW/MSYS to make sure at least that platform is okay for you. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |