Re: [Plplot-devel] Wholesale WIN32 changes in our build system logic

[Alan W. I. <ir...@be...>]

On 2013-07-16 12:49+0200 Arjen Markus wrote:

> Hi Alan,
>
> I have attached the results of the test as a gzipped tar file.

Thanks for those results.  Here are some issues I spotted.

1. Clearly my attempt to quiet the "WIN32 not defined on Cygwin"
warning messages didn't work in the slightest so I am now following
directions exactly (revision 12425) by not setting
CMAKE_LEGACY_CYGWIN_WIN32 as an ordinary non-cached variable. Instead,
the directions say to quiet the warning messages for CMake 2.8.4 and
above (the current case) you must set that variable as a cached
variable. To do that, please use -DCMAKE_LEGACY_CYGWIN_WIN32=0 as a cmake
command option in your automated testing script for Cygwin just to see
if that finally gets rid of those annoying warnings.

2. Although it didn't affect anything this time for unknown reasons,
please use -DTEST_DYNDRIVERS=OFF in your automatic testing script
for the reasons discussed before.

> Note 1: The non-interative test fails because the file tclIndex is not
> present in the examples/tcl directory.

Debugging issues like this is why the VERBOSE=1 option is so useful.
Please look at make.out where an attempt is made to create that file:

[ 52%] Generating tclIndex
cd /cygdrive/d/plplot-svn/build-cygwin-dll/examples/tcl && /bin/tclsh /cygdrive/d/plplot-svn/plplot/scripts/mktclIndex -tcl
make[3]: Leaving directory `/cygdrive/d/plplot-svn/build-cygwin-dll'
/usr/bin/cmake.exe -E cmake_progress_report /cygdrive/d/plplot-svn/build-cygwin-dll/CMakeFiles  29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47
[ 74%] Built target tclIndex_examples_tcl

The equivalent works fine on Linux.  Please try to replicate those
exact commands by hand to see what the issue might be on Cygwin.
Note, the above commands were generated by the CMake logic in
examples/tcl/CMakeLists.txt which currently reads

add_custom_command(
   OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/tclIndex
   COMMAND ${TCL_TCLSH} ${MKTCLINDEX} ${MKTCLINDEX_ARGS}
   DEPENDS ${tclIndex_DEPENDS}
   WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
   )

So if some change needs to be made to the CMake logic, it will be in
the above area or else the CMake logic where the CMake MKTCLINDEX or
MKTCLINDEX_ARGS variables are defined.  Or if a change needs
to be made to mktclIndex for Cygwin, I am sure you will know what
is required.  So if you can somehow solve this issue,
I look forward to your commit.

Of course, if you cannot generate tclIndex by hand by some variation
of the above mktclIndex command (i.e., there is probably a Cygwin bug
that you cannot do anything about other than to report to Cygwin),
then to proceed further with that platform you must specify
-DENABLE_tcl=OFF until that Cygwin bug is fixed.

>
> Note 2: the current configuration does not build the wingcc device,
> which is the most common interactive device on Windows. I found that
> out when I tried to see if the Tcl examples would work. (They do,
> the xfig file I generated for example 1 is identical to the C one)

The test_noninteractive target only builds the minimum (which does not
include the interactive wingcc device) needed to do the non-
interactive tests.  That is by design so the test will be run as
rapidly as possible with only the required dependencies built.

If instead you want to test all interactive devices (including
wingcc), then run the test_interactive target (before or after
test_noninteractive since the dependencies insure the order for
invoking these targets does not matter).

I look forward to the command-line ouput for both those targets
(please captured as test_noninteractive.out and test_interactive out
in your next tarball).

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________