#161 plplot-5.11: deprecated wxpng component of wxwidgets driver generates broken build

The wxwidgets driver seems broken as of 5.11:

Scanning dependencies of target wxwidgets
make[2]: Leaving directory '/var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0_build'
make -f drivers/CMakeFiles/wxwidgets.dir/build.make drivers/CMakeFiles/wxwidgets.dir/build
make[2]: Entering directory '/var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0_build'
/usr/bin/cmake -E cmake_progress_report /var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0_build/CMakeFiles 97
[ 98%] Building CXX object drivers/CMakeFiles/wxwidgets.dir/wxwidgets.cpp.o
cd /var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0_build/drivers && /usr/bin/x86_64-pc-linux-gnu-g++ -DPLPLOT_HAVE_CONFIG_H -Dwxwidgets_EXPORTS -march=corei7-avx -O2 -pipe -fPIC -I/var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0/include -I/var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0/lib/qsastime -I/var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0/lib/nistcd -I/var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0_build -I/var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0_build/include -I/usr/lib64/wx/include/gtk2-unicode-release-2.8 -I/usr/include/wx-2.8 -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D__WXGTK__ -DUSINGDLL -o CMakeFiles/wxwidgets.dir/wxwidgets.cpp.o -c /var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0/drivers/wxwidgets.cpp
/var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0/drivers/wxwidgets.cpp: In function ‘void plD_init_wxpng(PLStream)’:
/var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0/drivers/wxwidgets.cpp:231:5: error: ‘wxPLDevBase’ was not declared in this scope
wxPLDevBase dev;
^
/var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0/drivers/wxwidgets.cpp:231:18: error: ‘dev’ was not declared in this scope
wxPLDevBase* dev;
^
/var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0/drivers/wxwidgets.cpp:232:28: error: ‘common_init’ was not declared in this scope
dev = common_init( pls );
^
drivers/CMakeFiles/wxwidgets.dir/build.make:54: recipe for target 'drivers/CMakeFiles/wxwidgets.dir/wxwidgets.cpp.o' failed
make[2]: *** [drivers/CMakeFiles/wxwidgets.dir/wxwidgets.cpp.o] Error 1
make[2]: Leaving directory '/var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0_build'
CMakeFiles/Makefile2:2064: recipe for target 'drivers/CMakeFiles/wxwidgets.dir/all' failed
make[1]: *** [drivers/CMakeFiles/wxwidgets.dir/all] Error 2
make[1]: Leaving directory '/var/tmp/portage/sci-libs/plplot-5.11.0/work/plplot-5.11.0_build'
Makefile:136: recipe for target 'all' failed
make: *** [all] Error 2

Looking into this, all declarations of wxPLDevBase reside in deprecated_HEADERS.h, hence it seems there's something amiss. Gentoo bug link as well: https://bugs.gentoo.org/show_bug.cgi?id=547254

[Alan W. Irwin]

Note that code with undeclared wxPLDevBase can only be reached when -DPLD_wxpng=ON so I have changed the subject line appropriately. Furthermore, -DPLD_wxpng should be OFF by default so you should review your cmake options to figure out why -DPLD_wxpng=ON in your case. The reason for that default is wxpng never worked from the start. See our recent discussion of wxpng at http://comments.gmane.orggmane.comp.graphics.plplot.devel/4171 where the choices discussed were either to get rid of wxpng completely or else to fix it properly.

[Anonymous]

Thank you, I can confirm that with -DPLD_wxpng=OFF, everything builds.

[Phil Rosenberg]

I'm not going to look into this any further for now as the focus is on getting the interactive part of wxWidgets working. In addition in wxWidgets 3.0 on Ubuntu there are issues with creating GUI objects (e.g. fonts) when not within a GUI program so I am not sure this is possible now (but nor am I sure it is impossible).