[Plib-devel] Re: [PATCH] ssg/ssgLoadAC.cxx: fix potential crash; accept DOS line endings
Brought to you by:
sjbaker
From: Melchior F. <a86...@un...> - 2003-07-03 07:07:44
|
* Frederic Bouvier -- Thursday 03 July 2003 08:51: > There is no problem either under Linux or Windows using MSVC. > In the first case, there is no CR, in the second, the CR is > consumed by the file routines when the file is open in text mode. > > The problem arise when the file is read by cygwin that is > configured with unix line endings, opening the file in binary > mode. So what? Users are confronted with the error message "ac_to_gl: Unrecognised token ''". That's not made up, but reality. And, despite violating the ac spec, these files happen to contain \r\n, be it only on cygwin systems. And that's no surprise, given that $ file a320-fb.ac a320-fb.ac: ASCII text What' wrong with being tolerant? It may be desirable, though, to output a warning. m. |