Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#254 CVS: imagebase cannot handle compressed camera images

closed
nobody
Player (393)
5
2008-02-18
2008-02-17
Paul Osmialowski
No

None of the drivers that use this class cannot handle compressed images. My patch fixes this. I was testing it with simpleshape driver which will be also bugfixed soon.
I was working with CVS snapshot taken 2008.02.17.

Discussion

  • player-20080217/server/drivers/base/imagebase.h

     
    Attachments
  • player-20080217/server/drivers/base/imagebase.cc

     
    Attachments
  • Logged In: YES
    user_id=1245830
    Originator: YES

    File Added: imagebase.cc.diff

     
  • Toby Collett
    Toby Collett
    2008-02-17

    • labels: --> Player
     
  • Toby Collett
    Toby Collett
    2008-02-18

    Logged In: YES
    user_id=974361
    Originator: NO

    rather than duplicating the uncompression code why not just use the camera uncompress driver?

     
  • Logged In: YES
    user_id=1245830
    Originator: YES

    using camerauncompress driver has few disadvantages:
    1. it creates one more thread to operate
    2. it causes few more copying of image data
    3. it's uncomfortable for unexperienced users
    in facts uncompresion code isn't duplicated per se as it only calls function from libplayerjpeg, I guess it has more advantages than code overhead (duplication) it causes. Other drivers (vide cmvision) also do that and it makes Player configuration file looks better and shorter.

     
  • Toby Collett
    Toby Collett
    2008-02-18

    Logged In: YES
    user_id=974361
    Originator: NO

    true, seems to justify that small amount of code being repeated, patch has been applied, thanks for the contribution

     
  • Toby Collett
    Toby Collett
    2008-02-18

    • status: open --> closed