From: Sidney C. <si...@ji...> - 2006-10-28 23:10:25
|
Hi all, As I am trying to familiarize myself with the innards of Player/Stage these days, I am looking at a good deal of the source code of both packages. As a result of this, I have encountered about a dozen small mistakes so far: typos, minor errors in the comments (resulting from copying without a proper update), some minor programming errors, and errors in the automake stuff (files not being properly listed in Makefile.am where they should - stuff like that). It would be nice to be able to contribute these small improvements back into the source tree, and I wonder how to best go about doing this: * shall I send individual mails for each minor bug to this mailing list? * shall I gather the patches relative to the CVS Head and provide that to someone? I am working with 2.0.3 at the moment, so I would have to sync the improvements to the latest version. * Is it possible to get direct SVN/CVS access? (probably not just yet, but this would be most convenient of course). Please advice! Best regards, Sidney |
From: Toby C. <tco...@pl...> - 2006-10-29 06:33:46
|
Best bet at the moment would be to collect as one big patch and post that to the patches section on players source forge page. Toby Sidney Cadot wrote: > Hi all, > > As I am trying to familiarize myself with the innards of Player/Stage > these days, I am looking at a good deal of the source code of both > packages. As a result of this, I have encountered about a dozen small > mistakes so far: typos, minor errors in the comments (resulting from > copying without a proper update), some minor programming errors, and > errors in the automake stuff (files not being properly listed in > Makefile.am where they should - stuff like that). > > It would be nice to be able to contribute these small improvements > back into the source tree, and I wonder how to best go about doing this: > > * shall I send individual mails for each minor bug to this mailing list? > * shall I gather the patches relative to the CVS Head and provide > that to someone? I am working with 2.0.3 at the moment, so I would > have to sync the improvements to the latest version. > * Is it possible to get direct SVN/CVS access? (probably not just > yet, but this would be most convenient of course). > > Please advice! > > Best regards, Sidney > > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > Playerstage-developers mailing list > Pla...@li... > https://lists.sourceforge.net/lists/listinfo/playerstage-developers > |
From: Radu B. R. <ru...@cs...> - 2006-10-29 09:57:53
|
I would also try to give an itemized description of the small patches, so we can see if all of them are ok for insertion, or just some. Cheers, Radu. Toby Collett wrote: > Best bet at the moment would be to collect as one big patch and post > that to the patches section on players source forge page. > > Toby > > Sidney Cadot wrote: >> Hi all, >> >> As I am trying to familiarize myself with the innards of Player/Stage >> these days, I am looking at a good deal of the source code of both >> packages. As a result of this, I have encountered about a dozen small >> mistakes so far: typos, minor errors in the comments (resulting from >> copying without a proper update), some minor programming errors, and >> errors in the automake stuff (files not being properly listed in >> Makefile.am where they should - stuff like that). >> >> It would be nice to be able to contribute these small improvements >> back into the source tree, and I wonder how to best go about doing this: >> >> * shall I send individual mails for each minor bug to this mailing list? >> * shall I gather the patches relative to the CVS Head and provide >> that to someone? I am working with 2.0.3 at the moment, so I would >> have to sync the improvements to the latest version. >> * Is it possible to get direct SVN/CVS access? (probably not just >> yet, but this would be most convenient of course). >> >> Please advice! >> >> Best regards, Sidney -- | Radu Bogdan Rusu | http://rbrusu.com/ | http://www9.cs.tum.edu/people/rusu/ | Intelligent Autonomous Systems | Technische Universitaet Muenchen |
From: Sidney C. <si...@ji...> - 2006-10-29 09:24:55
|
On Oct 29, 2006, at 7:35, Toby Collett wrote: > Best bet at the moment would be to collect as one big patch and post > that to the patches section on players source forge page. Sounds reasonable. Some questions: - What is the most convenient directory to run 'patch' ? I looked at a few patches and it seems that there is no hard-and-fast rule. - Are there plans to migrate from CVS to Subversion? - Is there a release date / agreed-upon release cycle? Best regards, Sidney |
From: Brian G. <br...@ge...> - 2006-10-29 16:13:58
|
On Oct 29, 2006, at 1:24 AM, Sidney Cadot wrote: > > On Oct 29, 2006, at 7:35, Toby Collett wrote: > >> Best bet at the moment would be to collect as one big patch and post >> that to the patches section on players source forge page. The patch tracker is definitely the place to contribute patches. In terms of the number of patches, I'd prefer something in the middle: a modest number of patches that are broken up by what they do. For example, if you're fixing typos in comments in a bunch of files, that would all go in one patch. If you're making significant changes to a particular component (e.g., a driver or client library), that would go in its own patch. Use your best judgement to break them up. > - What is the most convenient directory to run 'patch' ? I looked at a > few patches and it seems that there is no hard-and-fast rule. It's easiest for me to integrate if you run diff from the top-level source directory, e.g., player-2.0.3. To make it really easy for me, checkout player with the 'release-2-0-patches' tag (that's the 2.0.x branch), make your changes in that working copy, then use 'cvs diff' to make the patch. After applying the patch to release-2-0-patches, I'll join the relevant bits over to HEAD (which will become 2.1). > - Are there plans to migrate from CVS to Subversion? We've been intending to do this for a while, but haven't yet gotten around to it. > > - Is there a release date / agreed-upon release cycle? It varies. Bugfix releases come out when we deem them necessary. For major releases, we make a roadmap and set a target date when we're getting ready. We'll start this soon for Player 2.1. brian. |