From: brian g. <bg...@po...> - 2002-07-03 23:13:36
|
hi all, i've branched player, stage, and rtk2 at 1.2 with the tag 'release-1.2-patches'. we'll use this branch to bugfix and create patches for 1.2, until we release 1.3. i've already made the following fixes to Player on that branch (i've also duplicated the fixes, except for the first one, on HEAD): - applied Richard's 'Player-1.2.2-diff' patch (rich: did you apply this to HEAD already?) - applied Reed's (examples/c++/)'randomwalk.cc.patch' patch - fixed user-reported bug in examples/c++/laserobstacleavoid.cc - fixed minor user-reported bug in client_libs/c++/laserproxy.h - changed examples/c++/forage.cc so that it drives faster do you have anything to add to this list? if so, let me know (or make the fix yourself on the branch). my plan is to release a new patch and possibly a new version (1.2.1? 1.2.3?) early next week. does anything need patching in Stage? (rich: i don't get a segfault when sonar() is used without predefined geometry; i get functional sonars that are colocated at the robot's origin) brian. |
From: Richard V. <va...@hr...> - 2002-07-03 23:40:28
|
On Wed, 3 Jul 2002, brian gerkey wrote: > hi all, > > i've branched player, stage, and rtk2 at 1.2 with the tag > 'release-1.2-patches'. we'll use this branch to bugfix and create > patches for 1.2, until we release 1.3. > > i've already made the following fixes to Player on that branch (i've > also duplicated the fixes, except for the first one, on HEAD): > > - applied Richard's 'Player-1.2.2-diff' patch (rich: did you apply > this to HEAD already?) yes, HEAD includes those changes. - applied Reed's (examples/c++/)'randomwalk.cc.patch' patch > - fixed user-reported bug in examples/c++/laserobstacleavoid.cc > - fixed minor user-reported bug in client_libs/c++/laserproxy.h > - changed examples/c++/forage.cc so that it drives faster > > do you have anything to add to this list? if so, let me know (or make > the fix yourself on the branch). my plan is to release a new patch and > possibly a new version (1.2.1? 1.2.3?) early next week. nothing just now. > does anything need patching in Stage? (rich: i don't get a segfault > when sonar() is used without predefined geometry; i get functional sonars > that are colocated at the robot's origin) reported that bug from memory - just tried it again, and it's playerv that segfaults. Any clues andrew? GDB trace: Starting program: /home/vaughan/PS/player/utils/playerv/playerv [New Thread 1024 (LWP 4763)] PlayerViewer 1.2 Connecting to [localhost:6665] [New Thread 2049 (LWP 4779)] [New Thread 1026 (LWP 4780)] <program runs fine until I try to view sonars, then:> Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 1024 (LWP 4763)] 0x080548af in rtk_canvas_lock () (gdb) bt #0 0x080548af in rtk_canvas_lock () #1 0x08056238 in rtk_fig_origin () #2 0x08050afb in sonar_update (sonar=0x8094b48) at dev_sonar.c:112 #3 0x0804ce88 in main (argc=1, argv=0xbffff4c4) at playerv.c:151 #4 0x40308306 in __libc_start_main (main=0x804cad4 <main>, argc=1, ubp_av=0xbffff4c4, init=0x804c14c <_init>, fini=0x8059370 <_fini>, rtld_fini=0x4000d2dc <_dl_fini>, stack_end=0xbffff4bc) at ../sysdeps/generic/libc-start.c:129 R. > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > No, I will not fix your computer. > http://thinkgeek.com/sf > _______________________________________________ > Playerstage-developers mailing list > Pla...@li... > https://lists.sourceforge.net/lists/listinfo/playerstage-developers > -- Richard Vaughan HRL Laboratories [va...@hr...] |
From: ahoward <ah...@po...> - 2002-07-04 00:12:43
|
Ok, I fixed this in HEAD. Brian: will you add this to the patch, please? Note that this bug is not in the 1.2 release; it was introduced when the sonar count was changed from 16 to 24 (post-release). Both libplayerc and playerv were expecting 16 sonars, so they barfed. I've fixed it so they use the sonar count declared in messages.h. Question: what is the sonar count in release-1.2-patches? A. On Wed, 3 Jul 2002, Richard Vaughan wrote: > On Wed, 3 Jul 2002, brian gerkey wrote: > > > hi all, > > > > i've branched player, stage, and rtk2 at 1.2 with the tag > > 'release-1.2-patches'. we'll use this branch to bugfix and create > > patches for 1.2, until we release 1.3. > > > > i've already made the following fixes to Player on that branch (i've > > also duplicated the fixes, except for the first one, on HEAD): > > > > - applied Richard's 'Player-1.2.2-diff' patch (rich: did you apply > > this to HEAD already?) > > yes, HEAD includes those changes. > > - applied Reed's (examples/c++/)'randomwalk.cc.patch' patch > > - fixed user-reported bug in examples/c++/laserobstacleavoid.cc > > - fixed minor user-reported bug in client_libs/c++/laserproxy.h > > - changed examples/c++/forage.cc so that it drives faster > > > > do you have anything to add to this list? if so, let me know (or make > > the fix yourself on the branch). my plan is to release a new patch and > > possibly a new version (1.2.1? 1.2.3?) early next week. > > nothing just now. > > > does anything need patching in Stage? (rich: i don't get a segfault > > when sonar() is used without predefined geometry; i get functional sonars > > that are colocated at the robot's origin) > > reported that bug from memory - just tried it again, and it's playerv that > segfaults. Any clues andrew? > > GDB trace: > > Starting program: /home/vaughan/PS/player/utils/playerv/playerv > [New Thread 1024 (LWP 4763)] > PlayerViewer 1.2 > Connecting to [localhost:6665] > [New Thread 2049 (LWP 4779)] > [New Thread 1026 (LWP 4780)] > > <program runs fine until I try to view sonars, then:> > > Program received signal SIGSEGV, Segmentation fault. > [Switching to Thread 1024 (LWP 4763)] > 0x080548af in rtk_canvas_lock () > (gdb) bt > #0 0x080548af in rtk_canvas_lock () > #1 0x08056238 in rtk_fig_origin () > #2 0x08050afb in sonar_update (sonar=0x8094b48) at dev_sonar.c:112 > #3 0x0804ce88 in main (argc=1, argv=0xbffff4c4) at playerv.c:151 > #4 0x40308306 in __libc_start_main (main=0x804cad4 <main>, argc=1, > ubp_av=0xbffff4c4, init=0x804c14c <_init>, fini=0x8059370 <_fini>, > rtld_fini=0x4000d2dc <_dl_fini>, stack_end=0xbffff4bc) > at ../sysdeps/generic/libc-start.c:129 > > > R. > > > ------------------------------------------------------- > > This sf.net email is sponsored by:ThinkGeek > > No, I will not fix your computer. > > http://thinkgeek.com/sf > > _______________________________________________ > > Playerstage-developers mailing list > > Pla...@li... > > https://lists.sourceforge.net/lists/listinfo/playerstage-developers > > > > -- > Richard Vaughan > HRL Laboratories [va...@hr...] > > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > No, I will not fix your computer. > http://thinkgeek.com/sf > _______________________________________________ > Playerstage-developers mailing list > Pla...@li... > https://lists.sourceforge.net/lists/listinfo/playerstage-developers > Andrew Howard email: ah...@po... Department of Computer Science http: www-robotics.usc.edu/~ahoward University of Southern California phone: 1 (213) 740 6416 Los Angeles, CA, U.S.A. 90089-0781 fax: 1 (213) 740 7512 << Insert pithy saying here >>> |
From: brian g. <bg...@po...> - 2002-07-08 00:50:35
|
ahoward scribed: > > > Ok, I fixed this in HEAD. Brian: will you add this to the patch, please? > > Note that this bug is not in the 1.2 release; it was introduced when the > sonar count was changed from 16 to 24 (post-release). Both libplayerc and > playerv were expecting 16 sonars, so they barfed. I've fixed it so they > use the sonar count declared in messages.h. > > Question: what is the sonar count in release-1.2-patches? > the sonar count is (and will remain) 16 in the patch branch, so i won't add this playerv fix, since it wouldn't make any difference. btw, i haven't received any other additions for patches, so i'm closing the patching immediately; i'll prepare a bugfix/patch release tonight or tomorrow. brian. |