From: Toby C. <tco...@pl...> - 2008-06-16 03:44:33
|
Hi, Player 2.1.1 has now been release containing this fix, thanks for the work spotting, fixing and testing Toby 2008/6/16 Chris Chambers <chr...@gm...>: > > Should this change be implemented in the PlayerTime class? Currently there > is a global PlayerTime* GlobalTime which uses the WallClockTime. Should it > be made instead so that in globals.cc GlobalTime is made as a pointer to a > different class which uses clock_gettime (for linux, on OSX it would > continue to be a WallClockTime object), given how much better to use it is > (not going backwards in time and all). This might make everything simpler as > you then have all you time functions in a single place and just call > GlobalTime->GetTime() whenever you want to find the time. It also means that > internal player drivers currently using the globalTime would use the faster > and more accurate clock_gettime(). > > ~Chris > > > On Mon, Jun 16, 2008 at 12:21 PM, Chris Chambers < > chr...@gm...> wrote: > >> I can confirm that 2-1 now builds on OSX. >> >> >> On Mon, Jun 16, 2008 at 9:44 AM, Toby Collett < >> tco...@pl... <tcollett%2Bp...@pl...>> wrote: >> >>> Hi, >>> I have applied this patch to SVN 2-1, can some one please confirm SVN >>> 2-1 now builds on OSX? >>> >>> Toby >>> >>> Kevin Barry wrote: >>> > I just submitted a patch for 2.1.0, I changed configure.ac though I >>> > don't know CMake so someone else will have to figure out that part. >>> > >>> > >>> http://sourceforge.net/tracker/index.php?func=detail&aid=1994158&group_id=42445&atid=433166 >>> > >>> > It's basically the same as yours, however mine uses the replace/ setup >>> > rather than ifdef's inside messages.cc >>> > >>> > On Sun, Jun 15, 2008 at 6:47 AM, Chris Chambers >>> > <chr...@gm...> wrote: >>> > >>> >> Hey, >>> >> Commit 6498 (Merged wait timout from 2-1) added a timeout to >>> message.cc >>> >> that uses clock_getttime() from librt.I haven't been able to find this >>> real >>> >> time library for OSX, has anyone else using player on a mac managed to >>> get >>> >> it working? >>> >> I have got it compiling and working by changing it from: >>> >> clock_gettime(CLOCK_REALTIME, &tp); >>> >> >>> >> to this: >>> >> >>> >> #if _POSIX_TIMERS > 0 >>> >> >>> >> clock_gettime(CLOCK_REALTIME, &tp); >>> >> >>> >> #else >>> >> >>> >> struct timeval tv; >>> >> >>> >> gettimeofday(&tv, NULL); >>> >> >>> >> tp.tv_sec = tv.tv_sec; >>> >> >>> >> tp.tv_nsec = tv.tv_usec*1000; >>> >> >>> >> #endif >>> >> >>> >> However I needed to remove the rt from these two lines in >>> CMakeLists.txt in >>> >> libplayercore so I imagine that this would stop it working on linux: >>> >> >>> >> TARGET_LINK_LIBRARIES (playercore playerutils playererror playerxdr >>> ltdl dl >>> >> pthread rt) >>> >> >>> >> PLAYER_ADD_LINK_LIB (ltdl dl pthread rt) >>> >> >>> >> Is there a librt that works on OSX? otherwise can someone who knows >>> cmake >>> >> change the CMakeLists.txt so that rt is only included on non-mac >>> systems and >>> >> the above change to message.cc should fix it. >>> >> >>> >> Thanks for the help, >>> >> >>> >> ~Chris >>> >> >>> >> >>> ------------------------------------------------------------------------- >>> >> Check out the new SourceForge.net Marketplace. >>> >> It's the best place to buy or sell services for >>> >> just about anything Open Source. >>> >> http://sourceforge.net/services/buy/index.php >>> >> _______________________________________________ >>> >> Playerstage-developers mailing list >>> >> Pla...@li... >>> >> https://lists.sourceforge.net/lists/listinfo/playerstage-developers >>> >> >>> >> >>> >> >>> > >>> > >>> ------------------------------------------------------------------------- >>> > Check out the new SourceForge.net Marketplace. >>> > It's the best place to buy or sell services for >>> > just about anything Open Source. >>> > http://sourceforge.net/services/buy/index.php >>> > _______________________________________________ >>> > Playerstage-developers mailing list >>> > Pla...@li... >>> > https://lists.sourceforge.net/lists/listinfo/playerstage-developers >>> > >>> > >>> >>> >>> ------------------------------------------------------------------------- >>> Check out the new SourceForge.net Marketplace. >>> It's the best place to buy or sell services for >>> just about anything Open Source. >>> http://sourceforge.net/services/buy/index.php >>> _______________________________________________ >>> Playerstage-developers mailing list >>> Pla...@li... >>> https://lists.sourceforge.net/lists/listinfo/playerstage-developers >>> >> >> > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > _______________________________________________ > Playerstage-developers mailing list > Pla...@li... > https://lists.sourceforge.net/lists/listinfo/playerstage-developers > > -- This email is intended for the addressee only and may contain privileged and/or confidential information |