Re: [SFE-devel] SFExmlstarlet spec review

[Milan J. <mil...@xy...>]

Hi Logan,

Logan O'Sullivan Bruns píše v ne 19. 02. 2012 v 11:09 -0800:
> I'm new to pkgbuild. In general, I'm slowing making the transition
> from Solaris 10 to OpenIndiana. I'm hoping someone could review the
> attached spec file for XMLStarlet and also let me know what the
> procedure is for submitting or updating spec files in general?
> 
> Thanks,
>   logan

it looks very well. I would recommend 3 things:

1) it would be nice to add this copyright statement to header, if you
are willing to do that:

# This file and all modifications and additions to the pristine
# package are under the same license as the package itself.


2) add IPS_Package_Name, please

3) %description is nice to have if you have some

As for contribution, Laca is still admin of repository I believe, so you
have to ask him for commit rights. If you want I can commit this one for
you.

Best regards,

Milan