#19 support space(4)

open-accepted
general (26)
5
2008-10-14
2008-10-06
Andrew Dudman
No

pkgbuild-1.3.3/pkgbuild.pl.in

TODO item:
- add support for SVr4 "space files", see space(4) on Solaris

Here is my attempt at this. While at it, I also did the
analogous checkinstall fix.

Patch attached.

Discussion

    • status: open --> open-accepted
     
  • So, if I understand correctly you are introducing new sections:

    %checkinstall

    and

    %space

    The code for parsing those should be in rpm_spec.pm.in, seems to be missing from the attachment.
    For %checkinstall that sounds fine, but in the case of %space it would probably be nicer to
    add something to %files, e.g.

    %files
    %space (%_prefix, 500, 1)

    That said, I never actually used space files, so I'm open to other options.
    Implementing the %files thingie is a bit more work, though...

     
  • Andrew Dudman
    Andrew Dudman
    2008-10-19

    Yes, I want to introduce two new section blocks:
    %checkinstall
    %space

    Sorry for the incomplete patch. The missing rpm_spec.pm.in code is in the newly attached pkgbuild-space+checkinstall.diff.

    When I approached the case of %space, I thought %files block, like prototype(4), was only for file prototypes, that end up in pkgmap(4). The space(4) file goes beyond prototype(4), and accounts for space taken by installf(1M), done dynamically, say in postinstall script. Since %post is a section block, I went with %space as another.
    Take a look at my patch again. Your more knowledgeable on this than me. If you still like your idea better, I am willing to work on implementing it. I agree it will take a bit more work. Hey, is all this doomed, with Indiana's pkg system replacing SVr4 one. Is it worth it?
    File Added: pkgbuild-space+checkinstall.diff

     
  • Andrew Dudman
    Andrew Dudman
    2008-10-20

    File Added: pkgbuild-space+checkinstall.diff

     
  • Andrew Dudman
    Andrew Dudman
    2008-10-20

    pkgbuild support for SVr4 space and checkinstall