Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#9 Fixing ShowOnlyTop behaviour

closed
nobody
None
5
2012-03-29
2006-11-30
Thomas Martinsen
No

The code and documentation contradicts itself on the "ShowOnlyTop" option. The documention explains that it means it will only shows most active nicks in big/interesting numbers. But it includes "these didn't make it to the top" too.

(I realised I posted this into the wrong tracker, so I reposted it here into patches instead, sorry)

I have a patch to make it adhere to what the documentation says here:
--- pisg2/pisg/modules/Pisg/HTMLGenerator.pm 2006-11-01 10:56:11.000000000 +0100
+++ pisg/modules/Pisg/HTMLGenerator.pm 2006-11-29 00:55:34.000000000 +0100
@@ -2413,7 +2413,7 @@
$self->{cfg}->{activenicks2} = $top_nicks-$self->{cfg}->{activenicks};
}

  • (@top_active) = @top_active[0..($self->{cfg}->{activenicks}+$self->{cfg}->{activenicks2}-1)];
  • (@top_active) = @top_active[0..($self->{cfg}->{activenicks}-1)];
    $self->{stats}->{topactive_lines} = @top_active ? $self->{stats}->{lines}{$top_active[0]} : 1;

foreach (@top_active) {

Discussion