[Gaim-patches] [ gaim-Patches-1223021 ] fixes bug #1222552

[SourceForge.net <no...@so...>]

Patches item #1223021, was opened at 2005-06-17 21:35
Message generated for change (Comment added) made by rlaager
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223021&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Jason Roth (jroth2)
Assigned to: Richard Laager (rlaager)
Summary: fixes bug #1222552

Initial Comment:
As described in bug report #1222552, gaim will
disconnect the current msn session and corrupt
blist.xml when you try to add an msn screenname with a
space in it (e.g. "foo ba...@ho...").  This patch
adds a check to userlist.c in the form of a three line
if statement

if(strrchr(who, " ") == NULL)
{
   gaim_debug("msn", "MSN screennames cannot contain
spaces");
   return;
}

----------------------------------------------------------------------

>Comment By: Richard Laager (rlaager)
Date: 2005-07-03 00:59

Message:
Logged In: YES 
user_id=156487

This should also use gaim_notify_error() to inform the user 
instead of just silently dropping the add request. 

----------------------------------------------------------------------

Comment By: Jason Roth (jroth2)
Date: 2005-06-20 21:39

Message:
Logged In: YES 
user_id=1298163

yeah, sorry, i misread my man page.  strchr(who, " ") !=
NULL is better.

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2005-06-18 23:25

Message:
Logged In: YES 
user_id=156487

My man page says: 
       The strchr() and strrchr() functions return a pointer to  the  
matched 
       character or NULL if the character is not found. 
 
I also don't see the point of using strrchr. Wouldn't strchr do? 
 
Therefore, shouldn't this be something like: 
if (strchr(who, " ") != NULL) 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223021&group_id=235