[Gaim-patches] [ gaim-Patches-1207204 ] --disable-dropshadow configure option

[SourceForge.net <no...@so...>]

Patches item #1207204, was opened at 2005-05-23 12:55
Message generated for change (Comment added) made by seanegan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1207204&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Christopher (siege) O'Brien (taliesein)
Assigned to: Ethan Blanton (eblanton)
Summary: --disable-dropshadow configure option

Initial Comment:
This patch pokes the preprocessor logic in
src/gtkblist.c so that it's possible to explicitly
prevent the tooltip drop-shadow effect.

It's annoying to me. Nobody else probably gives a crap.

----------------------------------------------------------------------

>Comment By: Sean Egan (seanegan)
Date: 2005-06-04 21:28

Message:
Logged In: YES 
user_id=199625

Stu: I'm not positive I understand your question, but the
patch essentially removes the buddy list drop shadow hack,
leaving the code behind #ifdef's so if you *really* want it,
you can get at it.

----------------------------------------------------------------------

Comment By: Stu Tomlinson (nosnilmot)
Date: 2005-06-04 21:16

Message:
Logged In: YES 
user_id=309779

default disabled? so this will (by default) change the way
every distribution's build works, without warning, on the
"stable" oldstatus branch?

----------------------------------------------------------------------

Comment By: Christopher (siege) O'Brien (taliesein)
Date: 2005-06-04 20:12

Message:
Logged In: YES 
user_id=77326

applied the default-disabled patch to oldstatus after Sean
okay'd it, will work something similar into HEAD as well.

----------------------------------------------------------------------

Comment By: Christopher (siege) O'Brien (taliesein)
Date: 2005-06-02 01:25

Message:
Logged In: YES 
user_id=77326

Thy will be done.

The fresher patch disables drop shadows by default. If you
enable them (say by running ./configure with
CPPFLAGS="-DWANT_DROP_SHADOW"), then the existing checks for
compatability will ensure that it'll work for you.

Did a little cleaning/commenting of some of the macro logic
as well. Tested both with and without drop shadows, and both
build without complaints and run as expected. I don't have
an OSX box or an older GTK to test the compatability checks
with, but it looks right (assuming the old checks were correct)

----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2005-06-02 00:34

Message:
Logged In: YES 
user_id=199625

Just turn it off by default.

-s.

----------------------------------------------------------------------

Comment By: Christopher (siege) O'Brien (taliesein)
Date: 2005-06-02 00:29

Message:
Logged In: YES 
user_id=77326

I heard there was some distribution that was having issues
with the drop shadows, they may be interested in the patch
for their own package, I'm unsure...

Would it be acceptable with just the gtkblist.c bits of the
patch? That way someone could still explicitly disable it
with a CFLAG.

----------------------------------------------------------------------

Comment By: Mark Doliner (thekingant)
Date: 2005-05-31 23:45

Message:
Logged In: YES 
user_id=20979

I usually try to apply patches from frequent patch writers
even if I don't completely agree with them... but I think
I'm going to have to skip this one.  The implementation is
good, I just don't like the idea of adding a configure
option that very few people will use.

I'll leave this open for a little bit in case other people
thing the option is a good idea.

As an aside, I remember hearing that some recent versions of
xorg provide their own, built-in drop-shadow support?  We'll
want to not enable Gaim's drop-shadow in that instance, if
this is true.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1207204&group_id=235