From: SourceForge.net <no...@so...> - 2005-04-25 18:39:16
|
Patches item #1039796, was opened at 2004-10-04 03:36 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1039796&group_id=235 Category: None Group: None Status: Closed Resolution: Rejected Priority: 5 Submitted By: Evan Schoenberg (evands) Assigned to: Mark Doliner (thekingant) Summary: Create gaim_user_dir() if needed in buddyicon initialization Initial Comment: Whereas the other functions using gaim_user_dir() will create it if needed (e.g., the account saving and blist_sync() functions), the buddyicon.c function which relies upon it does not. This does not usually pose a problem for a gaim user, as surely they have an account and buddy list already when a usericon is retrieved. However, neither of these functions are used in my libgaim implementation; it would be helpful if a check were also done before caching the buddyicon cache path in gaim_buddy_icons_init(). This simple patch ensures that gaim_user_dir() exists before building the path to the usericon cache, cache_dir = g_build_filename(gaim_user_dir(), "icons", NULL); ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-04-25 14:39 Message: Logged In: YES user_id=20979 As far as I could tell, yes, it is actually created when we go to use it. And it's not just laziness... I was thinking, "What if someone deletes the ~/.gaim directory while Gaim is running?" It would be better to create the directory as shortly before writing to it as possible. ---------------------------------------------------------------------- Comment By: Evan Schoenberg (evands) Date: 2005-04-25 14:17 Message: Logged In: YES user_id=669684 Laziness in coding is always a virtue... but is it actually created when we go to use it? ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-04-24 18:37 Message: Logged In: YES user_id=20979 I don't really think we should be creating the directory until we use it. Do you have a reason for needing the directory to exist? ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2004-10-25 08:08 Message: Logged In: YES user_id=28833 Nathan, will you please look at this? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1039796&group_id=235 |