From: Mark D. <the...@us...> - 2005-07-20 05:38:47
|
Update of /cvsroot/gaim/gaim/src/protocols/sametime In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29629/src/protocols/sametime Modified Files: sametime.c Log Message: A bit more dewarnification. I also think I found a memleak in sametime. siege, could you please check that out sometime? Index: sametime.c =================================================================== RCS file: /cvsroot/gaim/gaim/src/protocols/sametime/sametime.c,v retrieving revision 1.1 retrieving revision 1.2 diff -u -d -p -r1.1 -r1.2 --- sametime.c 7 Jun 2005 02:52:39 -0000 1.1 +++ sametime.c 20 Jul 2005 02:43:09 -0000 1.2 @@ -2304,7 +2304,7 @@ static void im_recv_mime(struct mwConver } else if(g_str_has_prefix(type, "image")) { /* put images into the image store */ - char *d_dat; + guint8 *d_dat; gsize d_len; char *cid; int img; @@ -2325,16 +2325,20 @@ static void im_recv_mime(struct mwConver /* recall the image for dereferencing later */ images = g_list_append(images, GINT_TO_POINTER(img)); + /* TODO: Don't we need to g_free 'd_dat'?! */ + } else if(g_str_has_prefix(type, "text")) { /* concatenate all the text parts together */ - char *data, *txt; + guint8 *data; + char *txt; gsize len; gaim_mime_part_get_data_decoded(part, &data, &len); - txt = gaim_utf8_try_convert(data); + txt = gaim_utf8_try_convert((const char *)data); g_string_append(str, txt); g_free(txt); + /* TODO: Don't we need to g_free 'data'?! */ } } |