From: Luke S. <lsc...@us...> - 2004-04-17 02:12:08
|
Update of /cvsroot/gaim/web/htdocs In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv30629/htdocs Modified Files: version.php Log Message: (21:55:36) nosnilmot: LSchiere2: (brain mush) did I mention that warren's change to gaim version breaks our release notification plugin? (21:56:07) LSchiere2: mmm? (21:56:10) nosnilmot: ... and it can be fixed with a 1 line patch to the php script (21:56:45) nosnilmot: warren changed the version (as displayed in help->about etc.) to 0.76-6, release notification web script isn't expecting things like that (21:56:46) ***LSchiere2 is not following. how does his break it? (21:57:03) LSchiere2: yeah, but the notification script shouldn't depend on existing gaim version should it? (21:57:32) nosnilmot: the plugin sends current version to website, website either says nothing, or gives latest version with changelog (21:57:45) LSchiere2: i see (21:59:18) nosnilmot: I'll use 0.75-x as an example : http://gaim.nosnilmot.com/version.php?version=0.75-6&build=gaim vs http://gaim.nosnilmot.com/version.php?version=0.75&build=gaim (22:00:21) nosnilmot: both should return the changelog because 0.76 > 0.75-6 (22:01:31) nosnilmot: here's a one liner that copes with any (X.YY-ZZZZ) by stripping the Z's : http://www.nosnilmot.com/gaim/gaim-version.php.patch Index: version.php =================================================================== RCS file: /cvsroot/gaim/web/htdocs/version.php,v retrieving revision 1.1 retrieving revision 1.2 diff -u -d -p -r1.1 -r1.2 --- version.php 17 Nov 2003 22:12:03 -0000 1.1 +++ version.php 17 Apr 2004 02:11:57 -0000 1.2 @@ -9,6 +9,7 @@ if(!isset($version) || !isset($build)) e if(preg_match("/cvs/",$version)) $cvs = true; $my_ver = str_replace("cvs","", $version); +$my_ver = preg_replace("/-(\d+)$/","", $my_ver); if($build == "gaim-win32") $cur_ver = $current_win32_version; |