From: Christian H. <ch...@us...> - 2004-02-06 22:03:53
|
Update of /cvsroot/gaim/gaim/src/protocols/yahoo In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv21714 Modified Files: yahoo.c Log Message: It's an uncommon practice to use strlen("SOMETHING") && strncmp(...) as the value for a length parameter to a strncmp. I'm therefore assuming it's wrong, and fixing it. I'm also going to get some breakfast. I was thinking Lucky Charms, but we're about out of that, so I may go for bacon instead. Or I could go take my shower and get some donuts. It's a tough decision. Index: yahoo.c =================================================================== RCS file: /cvsroot/gaim/gaim/src/protocols/yahoo/yahoo.c,v retrieving revision 1.200 retrieving revision 1.201 diff -u -d -p -r1.200 -r1.201 --- yahoo.c 5 Feb 2004 16:28:50 -0000 1.200 +++ yahoo.c 6 Feb 2004 22:01:05 -0000 1.201 @@ -1922,8 +1922,8 @@ static void yahoo_web_pending(gpointer d GString *s; len = read(source, buf, sizeof(buf)-1); - if (len <= 0 || (strncmp(buf, "HTTP/1.0 302", strlen("HTTP/1.0 302") && - strncmp(buf, "HTTP/1.1 302", strlen("HTTP/1.1 302"))))) { + if (len <= 0 || (strncmp(buf, "HTTP/1.0 302", strlen("HTTP/1.0 302")) && + strncmp(buf, "HTTP/1.1 302", strlen("HTTP/1.1 302")))) { gaim_connection_error(gc, _("Unable to read")); return; } |