From: Linux User <user1102@ym...> - 2007-01-19 23:07:00
I have been running GAIM under gdb lately.
My first catch is this:
The code in out_cmd assumes that params in MsnCommand has been set, but
the code in msn_command_from_string does not always set the params,
leaving it NULL.
I think a check for cmd->params == NULL is needed around the two if's in
I have not followed out the logic, so maybe an error should be set also.
I hope this helps.
From: Sean Egan <seanegan@gm...> - 2007-01-19 23:56:26
On 1/19/07, Evan Schoenberg <evan.s@...> wrote:
> We're currently in code freeze. After gaim 2.0.0 is out,
> g_return_val_if_fail() protections should be added in
> msn_session_find_slplink() and similar lookup methods, and the method you
> mention should have a safety check as described. Please submit a patch
> doing this and I'll review it after 2.0.0 :)
It's a feature and string freeze. This would be a bug fix, and