Re: [Gaim-devel] CVS: gaim/src status.c,1.95,1.96

[Mark D. <ma...@ki...>]

On Wed, 15 Mar 2006 12:35:49 -0600, Richard Laager wrote
> On Tue, 2006-03-14 at 20:41 -0800, Mark Doliner wrote:
> > Modified Files:
> > 	status.c 
> > Log Message:
> > Fix sf bug #1443092, Events logging not working properly?
> > "signed on" and "signed off" for people in your buddy list
> > are now correctly logged to the system log.
> > 
> > Richard, someone had already left a note in this function
> > to make a change after the string freeze (I think it was
> > you).  We should still make a change after the string freeze,
> > but the change is different now than it was before this commit.
> 
> > +		/* After the string freeze, get rid of the above crap and use this. */
> > +		/*
> > +		tmp = g_strdup_printf(_("%s is now %s"), buddy_alias,
> > +							  gaim_status_get_name(new_status));
> > +		*/
> > +
> 
> Do we really want this? If I'm understanding this correctly, it removes
> the distinction between "signed on" and "came back", for example. I
> don't use the system log, so it doesn't matter to me much as a user, 
> but I'm not sure the people that do use the system log will like this.

My primary motivation was that doing it this way would allow it to work for
both independent and dependent statuses (although, we might not be using
independent statuses at all).  And it would also show a message when a buddy
goes from away to not available, for example.  I was thinking that if people
wanted to know the users previous status, they could look at the preceding
line in the system log.  But I guess that doesn't always work.

But about changes the printf to something like, "%s changed status from %s to %s"?

-Mark