From: Luke S. <lsc...@us...> - 2005-06-03 14:29:55
|
On Fri, Jun 03, 2005 at 10:02:46AM -0400, Etan Reisner wrote: > On Thu, 2 Jun 2005, Luke Schierer wrote: > > > On Thu, Jun 02, 2005 at 06:28:13PM -0400, Etan Reisner wrote: > > > I would suggest that we might want to try having gaim try gnome-open as > > > it's first attempt and use that iff we are running within Gnome (unless > > > we decide we want to default to that if it exists regardless of Gnome > > > running). This allows us to use the Gnome default for any people that > > > happen to be running Gnome, while also allowing them to use something > > > different for gaim (if they so choose), and it allows us not to > > > special-case Gnome in our code. > > > > I do not at all understand what you are describing here. Perhaps I'm > > being dense, but you seem to say "use this if we detect gnome" right > > after saying that's bad, and then continuing to say that it can be > > overridden. Perhaps you meant simply to default the preference to it? > > Sorry, I should probably have explained this more. Yes, I meant we > should default to a choice of 'Gnome default' in the preference page and > not removing the page entirely. From my quick glance at the code we > default to the first browser in our hard-coded list which exists on the > system. My suggestion was to move gnome-open to the top of the list so > that it gets selected. That way people who use Gnome never need to see > anything unless they go look, people who don't have gnome don't see it, > and people who use Gnome but want to change it can. And it keeps us from > special casing Gnome, which I think is a good idea. (Especially in light > of the whole Urgent/Demands Attention debate where we said in no > uncertain terms that we didn't like needing to write code specifically > for Gnome.) I *do* dislike, in no uncertain terms, special casing Gnome. :-) and this has already caused confusion, with non-developers commenting in reports (in #gaim and in the trackers) that gaim does have a browser page, and the fact that the person is in gnome is irrelvent, and I've had to step in and correct them. I think this is a sensible approach, as the typical Gnome user won't be mucking about in preferences anyway. luke > > > luke > > -Etan |