Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#2 wrong check of popen error

open
nobody
None
5
2012-07-06
2012-07-06
Pino Toscano
No

In src/festival.c, plugin_load function, there's a redeclaration of the errno variable; although, it seems that code should rather look at the return value of the popen invocation to check whether it succeeded, instead of errno (since it may also not be set[1]).
The attached patch fixes the check of popen errors, removing also a pclose invocation that is pointless (since "festival_pf" would be NULL there).

[1] http://pubs.opengroup.org/onlinepubs/9699919799/functions/popen.html

Discussion

  • Pino Toscano
    Pino Toscano
    2012-07-06

    popen check fix

     
    Attachments