#25 Fix smileys for protocols without per-protocol smileys

closed-accepted
Bill Tompkins
None
5
2006-01-17
2006-01-14
Richard Laager
No

My previous patching broke smilies for protocols with
no per-protocol smileys (e.g. IRC). I would prefer
there was a better way than what this patch does
(directly looking at imhtml->smiley_data), but at the
moment, there isn't. Some day when we rework the smiley
tree stuff, we'll make this sort of thing easy.

Discussion

  • Bill Tompkins
    Bill Tompkins
    2006-01-17

    Logged In: YES
    user_id=21203

    It looks like the log callback was missing the check for a
    lack of per-protocol smiley?

    I took this opportunity to refactor the smiley-adding code,
    pulling all of the per-protocol checks, and existing smiley
    checks, into create_smiley() (now
    create_smiley_if_absent()). I checked it out with AIM and
    IRC, and all seems happy (although the logs are displaying
    the "capable" message, which is encoded in an HTML tag, as
    text.... but that's something else)

     
  • Bill Tompkins
    Bill Tompkins
    2006-01-17

    • assigned_to: nobody --> obobo
    • status: open --> closed-accepted