#24 Fix for log-displaying handle

closed-accepted
Bill Tompkins
None
5
2006-01-13
2006-01-12
Richard Laager
No

When you accepted my log smiley patch, you modified it
incorrectly.

The "log-displaying" signal is a gtklog signal, not a
conversation signal. The way I coded it was correct.

I assume this was changed because
gaim_gtk_log_get_handle() was just added to Gaim's CVS
(by me).

So this means I was wrong when I said it would compile
against the beta.

The log smiley stuff won't work correctly unless this
patch is accepted. I realize that accepting this patch
means gaim-encryption CVS won't compile against Gaim
2.0.0beta1, but there's no avoiding that.

Discussion

  • Bill Tompkins
    Bill Tompkins
    2006-01-13

    • assigned_to: nobody --> obobo
    • status: open --> closed-accepted
     
  • Bill Tompkins
    Bill Tompkins
    2006-01-13

    Logged In: YES
    user_id=21203

    Sorry, I usually apply patches by hand (to force myself to
    inspect them in detail) and I goofed. Thanks for catching it.