From: Dan F <dfrankow@cs...> - 2004-03-20 00:32:54
Thanks again for Phpwiki. Before I leave for the weekend, I describe a
possible bug in the Back-links for 1.3.7. This bug is not critical. I
mention it because
a) It looks to be the same in pre-1.3.8 as well.
b) I am rooting around near that code, and may fix it in my copy
(1.3.7). I am happy to submit the fix if I do.
I'd like to know
1) Is this a bug, or intended behavior?
2) If it's a bug, should I submit it? If so, how?
3) If I fix it, should I submit the fix? If so, how?
Without further ado, the potential bug: Verified user links are not
recognized as wikilinks (e.g., for back-links at least for PearDB).
For the PearDB back-end, back-links are saved in the DB by using
TransformedText::getWikiPageLinks() (see CachedMarkup.php). This
function returns things recognized by the parser as
Cached_DynamicContent. If you look at the parser's Markup_wikiword
(InlineParser.php), it returns Cached_Wikilink, a derived class of
Cached_DynamicContent .. unless it _isWikiUserPage(), in which case it
makes up some HTML that is not derived from Cached_DynamicContent
(presumably in order to get the user icon in there). Thus, that HTML is
not recognized by getWikiPageLinks(), hence save(), hence does not show
up as a back-link (at least with PearDB backend). This doesn't seem
right. When I register as a user, I no longer show up in back-links?
If desired, a fix would be to make a Cached_Userlink object that is
derived from Cached_DynamicContent, and return that object from
Tell me what you think. If it's a bug, maybe I'll look at fixing.
Dan Frankowski dfrankow@... 612-626-8396