From: Tomas V.V.C. <co...@id...> - 2002-03-26 19:11:18
|
Hi, I was by casuality searching for info about what this Wiki idea is and reached PhpWiki. What was my surprise seeing that it uses PEAR DB and seeing also some hot discussions about the db abstraction libs. I'm one of the authors of PEAR DB and couldn't resist to read and take a look at the code. Some impressions/ideas: 1) PEAR DB sucks or not :-). PEAR DB is focused in usability and speed of coding (with unique features like bulk fetching, error handling, placeholders, easy API, etc). I have to agree with you in some things I've read like: outdated versions that comes with the PHP distribs, slower that ADODB or the lack of documentation. All this three points are changing now with the PEAR web, the DB version 3 and the PEAR manual (all of them in final tests state). I'm not a marketing guy, I'm just throwing here my own opinion. 2) About Wiki. I'm looking for an easy solution to one customer and that seems to fit very well on his needs (no html knowledge, no ftp abilities, you know.. a user). My only concern is about security and customization: is there some method to allow only certain users to add/edit contents? It is easy to change the appereance of the pages (templates, skins)? 3) About the PEAR DB Wiki driver: * I see that you are "fighting" with old DB distributions bugs, why you not: a) ship with your package a recent version of the lib, b) tell the users to update their PEAR installation (a new lazy way for updating PEAR on the way is: lynx -source http://pear.php.net/~cox/go-pear| sh). * Use sequences in _get_pageid() instead of MAX() to avoid race conditions * Use $dbh->limitQuery($sql, $from, $offset) in most_popular(), most_recent() instead of native LIMIT query to easy the migration for other backends. * _pear_error_message(). I see that you are removing the password from the DSN. JFYI The DSN is only exposed in the debugInfo when an error occurs during the connection. Btw IMHO is not really a good idea to show to the "users" any part of the DSN (well, even any info comming from $error->getDebugInfo(), well any non user related problem). * About the quoting problem. I still see some question and dubts, but I don't see there the PEAR DB error mentioned in PhpDatabaseAccessLibraries :-? * _pear_notice_filter(). Could someone tell me what errors and if they still persist? * next(). Good to see that the people need the "autofree" feature, one more reason to add it :-) * why you don't drop a mail to pea...@li... when find a bug or have some problem? :-) Sorry for this long post if it is out of place. Regards, Tomas V.V.Cox PS.- Please CC me as i'm not suscribed to this list |