Thread: [phpslash-users] Variables and Final TODO.
Brought to you by:
joestewart,
nhruby
From: Ajay S. <ss...@od...> - 2000-12-20 06:38:46
|
hello, Over the weekend I went through and removed ALL the presentation related variables (bgcolor, fontface, fontcolor, etc...). Just about ALL the html is in the templates where it belongs. This leaves only 14 variables in the Variable table which is cool. But I'm wondering why we even need the variable table anymore. Is there anything wrong with putting it all in a $cfg[] array that we initialize in config.php3? I know it sucks to init an array on every page load but that has to be better then consulting the database. The only variable that *needs* to be in the variable table is the 'poll_currentquestionid' since that changes all the time. But when I rewrite the poll module we can just store that info in the psl_poll_question table. Here's what's left in the TODO: - Fix the Block code. The Block Options should be sent back to PHP in a block_options[] array instead of block_option_1, block_option_2, etc... - Do a little house cleaning for unused functions (Not too serious as a TODO) - templify the calendar block and make the links work. - when you click on 'Add Story' the rest of the NavBar options disappear except for "Home". - Get all general config vars into config.php3, finalaize the most used functions for every page and import them into functions.inc (This obsoletes Slash.class, which I think has finaly been declared dead.) Vars that are only required for one page or that need to be dynamicly updated need to stay in the db. Things like basedir, rootdir, etc. can live in config.php3 - Clean up to make reading / editing easier in config.php3 (nathan) - Mostly done. Will finalize after everything moves in there - phpslash.org needs updating and needs to run 0.6 for release (Trollboy, Blake for Docs) (Again, half way: not sunning 0.6, but that'll come soon) - Icons ???? - Docs need updating (Coordinated by Blake) - Object method / propertiy lists - Add install guide (HTML and text flavors) (Sorta Done.. Needs help. Users: Please test / read/ comment) - Updated CREDITS - Update FAQ (module owners, URL's, mailing list signup has changed, etc...) - Make sure everything points at SourceForge. - Speed cleanups (ie: getStoriesForIndex gets a list of story_id's and sends each it to getStory, which in turn does another query and gets all the story stuff for the id and returns the HTML for the ONE story. So you have to do a query for EACH story.) ---------------------------------------------------------------- Satyajot (Ajay) Sharma ss...@od... Digital Odyssey System Administrator "You will find true love, or a missing sock" -- Bazooka Joe ---------------------------------------------------------------- |
From: nathan h. <nh...@ar...> - 2000-12-20 15:13:34
|
Looks good so far. I'm off to see the 'rents in Florida this afternoon. I should be able to keep up with email but I doubt I'll be able to work on phpslash till this time next week due to the accumlating lsit of chores my mom has been piling up for me (hook up network in office, fix dad's laptop, build them website, etc.. ). [more comments below.. damn Outlook Express.. i hate this thing gotta get me some pc-pine] ... nathan r. hruby: nh...@ar... Webmaster: UGA- Dept. of Drama http://www.drama.uga.edu ... ----- Original Message ----- From: Ajay Sharma <ss...@od...> To: PHPslash list <php...@li...> Sent: Tuesday, December 19, 2000 5:06 PM Subject: [phpslash-users] Variables and Final TODO. > > hello, > > Over the weekend I went through and removed ALL the presentation related > variables (bgcolor, fontface, fontcolor, etc...). Just about ALL the > html is in the templates where it belongs. > > This leaves only 14 variables in the Variable table which is cool. But > I'm wondering why we even need the variable table anymore. Is there > anything wrong with putting it all in a $cfg[] array that we initialize > in config.php3? I know it sucks to init an array on every page load but > that has to be better then consulting the database. Arrays work for me. I think some people will complain about not having a fuzzy GUI to admin stuff, but that's fine with me. I'd rather see the speed improvements. > > The only variable that *needs* to be in the variable table is the > 'poll_currentquestionid' since that changes all the time. But when I > rewrite the poll module we can just store that info in the > psl_poll_question table. > Exactly. [snip todo.. will get crackin' on it next week] |
From: Joe S. <jo...@be...> - 2000-12-20 16:30:28
|
On Tue, Dec 19, 2000 at 02:06:57PM -0800, Ajay Sharma wrote: > > hello, > > Over the weekend I went through and removed ALL the presentation related > variables (bgcolor, fontface, fontcolor, etc...). Just about ALL the > html is in the templates where it belongs. > > This leaves only 14 variables in the Variable table which is cool. But > I'm wondering why we even need the variable table anymore. Is there > anything wrong with putting it all in a $cfg[] array that we initialize > in config.php3? I know it sucks to init an array on every page load but > that has to be better then consulting the database. > Yeah, I've been thinking that their is going to be more passing around of a config array. Especially when we start to have "user" logins. > The only variable that *needs* to be in the variable table is the > 'poll_currentquestionid' since that changes all the time. But when I > rewrite the poll module we can just store that info in the > psl_poll_question table. > > Here's what's left in the TODO: > > - Fix the Block code. The Block Options should be sent back to PHP in a > block_options[] array instead of block_option_1, block_option_2, > etc... > I think it already does. Look at the diff in Block_i.class ( 11/27 1.20->1.21): http://cvs.sourceforge.net/cgi-bin/cvsweb.cgi/phpslash-ft/public_html/Block_i.class.diff?r1=1.20&r2=1.21&cvsroot=phpslash View the source of the blockAdmin.php3 page. > > - when you click on 'Add Story' the rest of the NavBar options disappear > except for "Home". > It's an admin page with no seclev. Any reason this shouldn't be the "normal" logged out choices? If not, this can be changed easily. > > - Speed cleanups (ie: getStoriesForIndex gets a list of story_id's and > sends each it to getStory, which in turn does another query and gets > all the story stuff for the id and returns the HTML for the ONE > story. So you have to do a query for EACH story.) > As far as the call to getStory, the index pages call getStories now either directly or indirectly, so the example isn't true any more, but there are some other speed cleanups that could be done. Joe > > ---------------------------------------------------------------- > Satyajot (Ajay) Sharma > ss...@od... > Digital Odyssey System Administrator > "You will find true love, or a missing sock" -- Bazooka Joe > ---------------------------------------------------------------- |
From: Ajay S. <ss...@od...> - 2000-12-27 06:22:16
|
Anyone know how to delete a directory in the CVS? We need to get rid of that backend directory. > > - Fix the Block code. The Block Options should be sent back to PHP in a > > block_options[] array instead of block_option_1, block_option_2, > > etc... > > I think it already does. Look at the diff in Block_i.class ( 11/27 > 1.20->1.21): > > http://cvs.sourceforge.net/cgi-bin/cvsweb.cgi/phpslash-ft/public_html/Block_i.class.diff?r1=1.20&r2=1.21&cvsroot=phpslash > > View the source of the blockAdmin.php3 page. you should be able to say, <INPUT TYPE=text NAME=optionname[] VALUE=""> <INPUT TYPE=text NAME=optionval[] VALUE=""> There's no need to force it in with optionname[1] and optionval[1]. But whatever, it works fine and it's better then optionname_1. :) I'm moving it out of the TODO. > > - when you click on 'Add Story' the rest of the NavBar options disappear > > except for "Home". > It's an admin page with no seclev. Any reason this shouldn't be the > "normal" logged out choices? If not, this can be changed easily. It works like expected now. I don't really like that we have to search for the word "Admin" in the $pagetitle to determine if this is an Admin page or not. There should be global variable or something to determine if we print out the admin menu or the default one. > As far as the call to getStory, the index pages call getStories now > either directly or indirectly, so the example isn't true any more, > but there are some other speed cleanups that could be done. What other speed cleanups are there? Lemmie rephrase that, what other speed cleanups are there that are CRITICAL to 0.6-FINAL? later, ajay ---------------------------------------------------------------- Satyajot (Ajay) Sharma ss...@od... Digital Odyssey System Administrator "You will find true love, or a missing sock" -- Bazooka Joe ---------------------------------------------------------------- |
From: Joe S. <jo...@be...> - 2000-12-27 14:51:15
|
On Tue, Dec 26, 2000 at 10:22:14PM -0800, Ajay Sharma wrote: > > Anyone know how to delete a directory in the CVS? We need to get rid of > that backend directory. > No, but here's an explanation how: http://cvsbook.red-bean.com/cvsbook.html#Removing_Directories Joe |
From: nathan r. h. <nh...@ar...> - 2000-12-27 15:03:28
|
on 12/27/00 9:49 AM, Joe Stewart at jo...@be... wrote: > On Tue, Dec 26, 2000 at 10:22:14PM -0800, Ajay Sharma wrote: >> >> Anyone know how to delete a directory in the CVS? We need to get rid of >> that backend directory. >> > > No, but here's an explanation how: > > http://cvsbook.red-bean.com/cvsbook.html#Removing_Directories > > > Joe > > _______________________________________________ > phpslash-users mailing list > php...@li... > http://lists.sourceforge.net/mailman/listinfo/phpslash-users > Don't do that please. We should leave them for the php3 folks as RDF parser examples since they can't use the block_render_rss class. -n |
From: Ajay S. <ss...@od...> - 2000-12-27 17:33:34
|
> Don't do that please. We should leave them for the php3 folks as > RDF parser examples since they can't use the block_render_rss class. Okay, I'm gonna throw some junk in there like url_test.php3 and backend.php3. later, ajay ---------------------------------------------------------------- Satyajot (Ajay) Sharma ss...@od... Digital Odyssey System Administrator "You will find true love, or a missing sock" -- Bazooka Joe ---------------------------------------------------------------- |