From: Leonardo S. <l.s...@gm...> - 2011-05-17 16:54:54
|
Jehan, Andreas and devs, > you forgot the translations files. Opss, sorry :/ > Here is a patch that drops all strings from language files related to the > slony plugin. > > It's based on Slony related categories found in the english.php file. I did > some scripting to find out strings that might still be used after applying > your patch and found just 2 of them: strexecute and strcluster. Which > actually makes a lot of sense as we use them in some other context. > > All other strings from those slony blocks in the english file are dropped in > this patch. Wow, thanks :) > Thx for your review and comment. Hopefully we'll be able to merge this > patches in your HEAD soon, then you'll be able to send us your first pull > request on github :) I did some tests with Selenium, with PostgreSQL 8.0 -> 9.1 beta, and it returns: "info(1305650271703): Executing: |clickAndWait | link=Databases | Element link=Databases not found | error(1305650271713): Element link=Databases not found warn(1305650271715): currentTest.recordFailure: Element link=Databases not found" and "info(1305650054459): Executing: |clickAndWait | link=Roles | | error(1305650054465): Element link=Roles not found warn(1305650054466): currentTest.recordFailure: Element link=Roles not found" Do you know why it happpens? I also put in my environment the PG 7.4, but I am having troubles with this version and ppa authentication. I am trying fix it right now. Thanks -- Atenciosamente Leonardo Augusto Sápiras [http://www.leonardosapiras.com.br] 2011/5/16 Jehan-Guillaume (ioguix) de Rorthais <io...@fr...>: > On 09/05/2011 11:16, Jehan-Guillaume (ioguix) de Rorthais wrote: >> >> On 03/05/2011 23:20, Jehan-Guillaume (ioguix) de Rorthais wrote: >>> >>> On 03/05/2011 02:16, Leonardo Sápiras wrote: >>>> >>>> Hi developers, >>>> >>>> My first activity, in the GSoC 2011, is drop the current plugin >>>> architecture. I dropped the code that has relation with it. This is >>>> necessary for I follow the next steps. >>> >>> yup >>> >>>> Attached my first patch. Andreas and Jehan, it's my first commit >>>> using git branches. Let me know if something is wrong. >>> >>> I don't have enough time today to review it seriously. I will in next >>> days ! >> >> Sorry Leonardo, I hadn't time during the week end, my current week looks >> pretty crazy and I'm heading to the pgcon2011 on sunday... >> >> I really hope I could find some time during the week, I'll do my best, >> but I can't promise I will. > > you forgot the translations files. > > Here is a patch that drops all strings from language files related to the > slony plugin. > > It's based on Slony related categories found in the english.php file. I did > some scripting to find out strings that might still be used after applying > your patch and found just 2 of them: strexecute and strcluster. Which > actually makes a lot of sense as we use them in some other context. > > All other strings from those slony blocks in the english file are dropped in > this patch. > > Thx for your review and comment. Hopefully we'll be able to merge this > patches in your HEAD soon, then you'll be able to send us your first pull > request on github :) > >> Andreas, do you have some time on your side ? >> >> Anyway, Leonardo, this first step shouldn't impact your next steps code. >> Please, keep going and start the next step, we'll catch up with you >> quickly. >> >> Thank you guys. > |