#172 custom ENUM types

open
None
5
2010-07-25
2010-07-25
Anonymous
No

phpPgAdmin's table insert functionality uses a basic text box for custom ENUM types, which, from a usability standpoint, is a pain, as the enums are type-safe and there's no easy method of looking them up for entry. phpMyAdmin solves this problem by including the enumeration values as a drop-down SELECT box.

I made a change to classes/database/Postgres.php to make phpPgAdmin pull the relevant enumeration information from pg_enum and pg_type and include the options as a drop-down box, which is attached.

Discussion

  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here


    Anonymous
    2010-07-25

    DIFF of changes from git

     
    Attachments
  • Hey,

    Thanks for this patch. Note that it shouldn't be a bug report, but a feature request. I moved this thread to the good category.

    The patch itself doesn't pay attention to the PostgreSQL version. We are supportingPG versions from 7.4 to 8.4 and 9.0 soon. Enum types only appeared in 8.3.

    Moreover, we never use directly pg_query in our code. You should use $this->execute(), while ! ->EOF, ->moveNext().

    Your request make a lot of sense and the patch sounds simple. You have to know that we limited man-power presently, especialy during the GSoC. I would be happy to fix your patch and commit it, but it might take some time.

    Please, could you send us another verison of your patch taking this comments in consideration ?

    Thanks in advance.

     
    • labels: 552184 -->
    • milestone: 984590 -->
    • assigned_to: chriskl --> ioguix