#446 pagination not changing page (through select)

5.1
closed-fixed
Robert Treat
None
5
2015-03-05
2014-05-09
timding
No

click tables
click select
click select all fields checkbox
now click pagination links goes back to tables name page instead of changing to desired page

Misc.php function printPages Line 1688 

Original:if ($i != $page) echo "<a class=\"pagenav\" href=\"?{$url}&amp;page={$i}\">$i</a>\n”;

Propose :if ($i != $page) echo "<a class=\"pagenav\" href=\"display.php?{$url}&amp;page={$i}\">$i</a>\n";

Discussion

  • ronlm
    ronlm
    2014-05-14

    There are a couple more lines that need to be changed - below is diff output.

    Thanks,
    Ron

    1688c1688
    <                                       if ($i != $page) echo "<a class=\"pagenav\" href=\"?{$url}&amp;page={$i}\">$i</a>\n";
    ---
    >                                       if ($i != $page) echo "<a class=\"pagenav\" href=\"display.php?{$url}&amp;page={$i}\">$i</a>\n";
    1693,1694c1693,1694
    <                                       echo "<a class=\"pagenav\" href=\"?{$url}&amp;page={$temp}\">{$lang['strnext']}</a>\n";
    <                                       echo "<a class=\"pagenav\" href=\"?{$url}&amp;page={$pages}\">{$lang['strlast']}</a>\n";
    ---
    >                                       echo "<a class=\"pagenav\" href=\"display.php?{$url}&amp;page={$temp}\">{$lang['strnext']}</a>\n";
    >                                       echo "<a class=\"pagenav\" href=\"display.php?{$url}&amp;page={$pages}\">{$lang['strlast']}</a>\n";
    
     
  • Robert Treat
    Robert Treat
    2015-03-05

    • status: open --> closed-fixed
    • assigned_to: Robert Treat
     
  • Robert Treat
    Robert Treat
    2015-03-05

    This is fixed in the 5.1 branch and in git master, and will be included in the next release. Thanks for the fix. BTW, if anyone is feeling ambitious, it would be great to add some test cases for this functionality; it's amazing it has been broken so long. Anyway, thanks again.