Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#279 _sequences/cycled broken (html)_

CVS
closed-fixed
Robert Treat
Sequences (2)
5
2006-07-03
2006-07-02
ailin
No

_sequences/cycled broken (html)_
When creating or altering a sequence, it always gets
created as cycled and it is impossible to turn the
cycled off.
This is caused by some weird html which results in code
such as <input value=" checked="checked"">

Here is a fix:

PS: Allowing bugreports only for registered users will
reduce your chances of making phpPgAdmin a better
software, you should reconsider that. Especially since
SourceForge does not accept my login attempts. Although
I guess I have to file a bugreport to SourceForge about
that (which I won't do), it is still annoying to YOUR
users. I tried more than seven times to submit this
goddamn tiny bug report. (Had to resort to using SSL to
log in AND check 'remember me' checkbox, yes I'm pissed
and will probably think twice about submitting a bug to
you again. I don't think I'm wrong when I claim that
most other users will give up earlier when faced with
such problems.)

Index: sequences.php

RCS file: /cvsroot/phppgadmin/webdb/sequences.php,v
retrieving revision 1.33
diff -w -B -i -b -d -U5 -r1.33 sequences.php
--- sequences.php 17 Jun 2006 12:57:36 -0000
1.33
+++ sequences.php 2 Jul 2006 01:27:36 -0000
@@ -232,12 +232,12 @@
echo "<tr><th class=\"data
left\">{$lang['strcachevalue']}</th>\n";
echo "<td class=\"data1\"><input
name=\"formCacheValue\" size=\"5\" value=\"",

htmlspecialchars($_POST['formCacheValue']), "\"
/></td></tr>\n";

echo "<tr><th class=\"data
left\"><label
for=\"formCycledValue\">{$lang['striscycled']}</label></th>\n";
- echo "<td class=\"data1\"><input
type=\"checkbox\" id=\"formCycledValue\"
name=\"formCycledValue\" value=\"",
-
(isset($_POST['formCycledValue']) ? '
checked="checked"' : ''), "\" /></td></tr>\n";
+ echo "<td class=\"data1\"><input
type=\"checkbox\" id=\"formCycledValue\"
name=\"formCycledValue\"",
+
(isset($_POST['formCycledValue']) ? '
checked="checked"' : ''), " /></td></tr>\n";

echo "</table>\n";
echo "<p><input type=\"hidden\"
name=\"action\" value=\"save_create_sequence\" />\n";
echo $misc->form;
echo "<input type=\"hidden\"
name=\"sequence\" value=\"",
htmlspecialchars($_REQUEST['sequence']), "\" />\n";
@@ -392,12 +392,12 @@
echo "<tr><th class=\"data
left\">{$lang['strcachevalue']}</th>\n";
echo "<td
class=\"data1\"><input name=\"formCacheValue\"
size=\"5\" value=\"",

htmlspecialchars($sequence->f['cache_value']), "\"
/></td></tr>\n";

echo "<tr><th class=\"data
left\"><label
for=\"formCycledValue\">{$lang['striscycled']}</label></th>\n";
- echo "<td
class=\"data1\"><input type=\"checkbox\"
id=\"formCycledValue\" name=\"formCycledValue\" value=\"",
-
($sequence->f['is_cycled'] ? ' checked="checked"' :
''), "\" /></td></tr>\n";
+ echo "<td
class=\"data1\"><input type=\"checkbox\"
id=\"formCycledValue\" name=\"formCycledValue\"",
+
($sequence->f['is_cycled'] ? ' checked="checked"' :
''), " /></td></tr>\n";

echo "</table>\n";
echo "<p><input type=\"hidden\"
name=\"action\" value=\"alter\" />\n";
echo $misc->form;
echo "<input type=\"hidden\"
name=\"sequence\" value=\"",
htmlspecialchars($_REQUEST['sequence']), "\" />\n";

Discussion

  • Robert Treat
    Robert Treat
    2006-07-03

    • assigned_to: chriskl --> xzilla
    • status: open --> closed-fixed
     
  • Robert Treat
    Robert Treat
    2006-07-03

    Logged In: YES
    user_id=204589

    The fact that you supplied an actual patch for your problem
    puts above at least 95% of the users out there... so I
    understand your pain, but afaik you don't actually have to
    log in to submit the bug, it just says "please log in " so
    it can tag the submission to someone. All of this being out
    of our control really, we just use what sourceforge gives
    us. In the future feel free to use the form found at
    http://phppgadmin.sourceforge.net/?page=support to contact
    the developers if the bug form is that much trouble.
    Incidentally I didnt see any way that your patch could
    actually fix the problem (it clears up the warning, but it
    doesnt actually make it work). If it did, please lmk the
    browser / php / pg version you're running... in the mean
    time I've implemented a fix in cvs if you interested in it.

     
  • Robert Treat
    Robert Treat
    2006-07-03

    Logged In: YES
    user_id=204589

    This issue has been resolved and is currently fixed in CVS. If
    you wish to acquire the fix, please download a nightly snapshot:

    http://phppgadmin.sourceforge.net/

    Note that you may have to wait up to 24 hours for the latest CVS
    changes to appear in the snapshot.

     
  • Logged In: YES
    user_id=82305

    SF itself recommends we don't allow anon postings. Quote:

    "Preventing anonymous posting will help to prevent abuse
    (such as spam) of your Tracker, increase the effectiveness
    of this system (you will know who submitted the issue and
    guarantee that you can reach them with your response), as
    well as helping to strengthen the SourceForge.net user
    community. We strongly recommend that you leave anonymous
    posting disabled, as to provide these benefits. Users will
    be able to post once they have logged in to the
    SourceForge.net site."